gpu:: Remove GpuDataManagerObserver::OnVideoMemoryUsageStatsUpdate().

gpu:: Remove GpuDataManagerObserver::OnVideoMemoryUsageStatsUpdate().

TaskManagerImpl is the only observer which requires this callback. In
order to get the video memory usage, TaskManagerImpl installs itself as
an observer, makes the request through GpuDataManager, and waits for the
observer callback to be called. Instead, change this so the request to
GpuDataManager::RequestVideoMemoryUsageStatsUpdate() includes the
callback that needs to run when the stats become available.

BUG=709332
Review-Url: https://codereview.chromium.org/2827323002
Cr-Commit-Position: refs/heads/master@{#466341}
Committed: https://chromium.googlesource.com/chromium/src/+/f2c71b4cd910cd4d3d4d3fe7091c992bb881e3f9

[sadrul, 2017-04-20 16:29:49]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 16:30:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-04-20 16:31:57]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[sadrul, 2017-04-20 16:32:17]

sadrul@chromium.org changed reviewers:
+ jbauman@chromium.org

[commit-bot: I haz the power, 2017-04-20 16:32:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 16:43:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 16:43:52]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jbauman, 2017-04-20 21:35:02]

https://codereview.chromium.org/2827323002/diff/20001/chrome/browser/task_man...
File chrome/browser/task_manager/sampling/task_manager_impl.cc (right):

https://codereview.chromium.org/2827323002/diff/20001/chrome/browser/task_man...
chrome/browser/task_manager/sampling/task_manager_impl.cc:477:
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
Won't this be called on the IO thread if it's run directly from the mojo
callback?

[sadrul, 2017-04-21 02:50:59]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 02:51:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-04-21 03:41:01]

https://codereview.chromium.org/2827323002/diff/20001/chrome/browser/task_man...
File chrome/browser/task_manager/sampling/task_manager_impl.cc (right):

https://codereview.chromium.org/2827323002/diff/20001/chrome/browser/task_man...
chrome/browser/task_manager/sampling/task_manager_impl.cc:477:
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
On 2017/04/20 21:35:02, jbauman wrote:
> Won't this be called on the IO thread if it's run directly from the mojo
> callback?

Very nice. Good catch! Yes, you are right. I missed the detail that
GpuDataManagerImplPrivate has a ObserverListThreadSafe instead of an
ObserverList. Thanks for catching this!

[jbauman, 2017-04-21 04:18:48]

lgtm

[commit-bot: I haz the power, 2017-04-21 04:27:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 04:27:50]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-04-21 04:31:59]

sadrul@chromium.org changed reviewers:
+ jam@chromium.org

[sadrul, 2017-04-21 04:32:00]

+jam@ for content/public and chrome/ changes.

[jam, 2017-04-21 14:59:49]

lgtm

[sadrul, 2017-04-21 15:21:20]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2017-04-21 15:21:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 15:26:05]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492788080118270,
"parent_rev": "9ec1a91b89f0dd7393a1c38fa84a7064d5984c1f", "commit_rev":
"f2c71b4cd910cd4d3d4d3fe7091c992bb881e3f9"}

[commit-bot: I haz the power, 2017-04-21 15:26:17]

Description was changed from

==========
gpu:: Remove GpuDataManagerObserver::OnVideoMemoryUsageStatsUpdate().

TaskManagerImpl is the only observer which requires this callback. In
order to get the video memory usage, TaskManagerImpl installs itself as
an observer, makes the request through GpuDataManager, and waits for the
observer callback to be called. Instead, change this so the request to
GpuDataManager::RequestVideoMemoryUsageStatsUpdate() includes the
callback that needs to run when the stats become available.

BUG=709332
==========

to

==========
gpu:: Remove GpuDataManagerObserver::OnVideoMemoryUsageStatsUpdate().

TaskManagerImpl is the only observer which requires this callback. In
order to get the video memory usage, TaskManagerImpl installs itself as
an observer, makes the request through GpuDataManager, and waits for the
observer callback to be called. Instead, change this so the request to
GpuDataManager::RequestVideoMemoryUsageStatsUpdate() includes the
callback that needs to run when the stats become available.

BUG=709332

Review-Url: https://codereview.chromium.org/2827323002
Cr-Commit-Position: refs/heads/master@{#466341}
Committed:
https://chromium.googlesource.com/chromium/src/+/f2c71b4cd910cd4d3d4d3fe7091c...
==========

[commit-bot: I haz the power, 2017-04-21 15:26:18]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f2c71b4cd910cd4d3d4d3fe7091c...