Fix HashTable growth strategy to be 2x instead of 4x

Fix HashTable growth strategy to be 2x instead of 4x

Review-Url: https://codereview.chromium.org/2827263004
Cr-Commit-Position: refs/heads/master@{#44783}
Committed: https://chromium.googlesource.com/v8/v8/+/75ce09b53392eee23f3c0c6727463f9d9ef9c73f

[Jakob Kummerow, 2017-04-20 16:57:20]

jkummerow@chromium.org changed reviewers:
+ verwaest@chromium.org

[Jakob Kummerow, 2017-04-20 16:57:21]

PTAL.

[Toon Verwaest, 2017-04-20 19:12:14]

Cool, lgtm. Let's hope we only see memory usage improvements and no perf
regressions ;-)

[Jakob Kummerow, 2017-04-20 19:40:30]

The CQ bit was checked by jkummerow@chromium.org

[commit-bot: I haz the power, 2017-04-20 19:40:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 20:00:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 20:00:07]

Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[Jakob Kummerow, 2017-04-21 17:01:16]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2017-04-21 17:01:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/2827263004/#ps20001
(title: "update CSA; fix test")

[commit-bot: I haz the power, 2017-04-21 17:01:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 17:31:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492794076040140,
"parent_rev": "ab4164ded30ea247f9a09accc5fa94e572a0416b", "commit_rev":
"75ce09b53392eee23f3c0c6727463f9d9ef9c73f"}

[commit-bot: I haz the power, 2017-04-21 17:31:36]

Description was changed from

==========
Fix HashTable growth strategy to be 2x instead of 4x
==========

to

==========
Fix HashTable growth strategy to be 2x instead of 4x

Review-Url: https://codereview.chromium.org/2827263004
Cr-Commit-Position: refs/heads/master@{#44783}
Committed:
https://chromium.googlesource.com/v8/v8/+/75ce09b53392eee23f3c0c6727463f9d9ef...
==========

[commit-bot: I haz the power, 2017-04-21 17:31:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/75ce09b53392eee23f3c0c6727463f9d9ef...

[Michael Achenbach, 2017-04-26 09:41:03]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2017-04-26 09:41:03]

FYI: flako points to this CL as the source for recent asan flakiness, e.g.:
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20ASAN/builds/19...

The script is WIP:
https://chromium-review.googlesource.com/c/475774/9

Called with:
tools/flako.py --to-revision 84dc8ed4c3e6c8c1e3005b2d2445c64328b139a4
--gs-prefix 'gs://chromium-v8/isolated/client.v8/V8 Linux64 ASAN/'

[Michael Achenbach, 2017-04-26 09:41:58]

On 2017/04/26 09:41:03, Michael Achenbach wrote:
> FYI: flako points to this CL as the source for recent asan flakiness, e.g.:
>
https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20ASAN/builds/19...
> 
> The script is WIP:
> https://chromium-review.googlesource.com/c/475774/9
> 
> Called with:
> tools/flako.py --to-revision 84dc8ed4c3e6c8c1e3005b2d2445c64328b139a4
> --gs-prefix 'gs://chromium-v8/isolated/client.v8/V8 Linux64 ASAN/'

Maybe this triggers OOMs when the test runs in parallel with other
resource-hungry tests?

[Toon Verwaest, 2017-04-26 09:43:28]

This CL reduces memory usage, so increasing OOM would surprise me ...

[Michael Achenbach, 2017-04-26 09:46:40]

Then some other sort of crasher?

[Toon Verwaest, 2017-04-26 09:53:30]

I'd be surprised since it just changes the calculation of 2 numbers.

[Michael Achenbach, 2017-04-26 09:54:44]

On 2017/04/26 09:53:30, Toon Verwaest wrote:
> I'd be surprised since it just changes the calculation of 2 numbers.

Well then the usual: Flushes out a different bug :) But somebody needs to look
at it...

[Michael Achenbach, 2017-04-26 09:56:02]

On 2017/04/26 09:54:44, Michael Achenbach wrote:
> On 2017/04/26 09:53:30, Toon Verwaest wrote:
> > I'd be surprised since it just changes the calculation of 2 numbers.
> 
> Well then the usual: Flushes out a different bug :) But somebody needs to look
> at it...

Bug for this is http://crbug.com/v8/6305 - lets talk there...