Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2827263002: Make MediaStreamVideoTrack::GetSettings return the track's frame rate. (Closed)

Created:
3 years, 8 months ago by Guido Urdaneta
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Make MediaStreamVideoTrack::GetSettings return the track's frame rate. It is currently returning the underlying source's native frame rate, which might be different from the adjusted rate of the track. BUG=711273 Review-Url: https://codereview.chromium.org/2817673004 Cr-Commit-Position: refs/heads/master@{#465257} (cherry picked from commit 935f9a2b54e4ac084ac81634a4a7afcd5de511bb) Review-Url: https://codereview.chromium.org/2827263002 . Cr-Commit-Position: refs/branch-heads/3071@{#78} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/b249dd212dea164750205c689434d0341a9ad266

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -7 lines) Patch
M content/renderer/media/media_stream_video_source.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M content/renderer/media/media_stream_video_track.h View 2 chunks +4 lines, -2 lines 0 comments Download
M content/renderer/media/media_stream_video_track.cc View 1 chunk +9 lines, -3 lines 0 comments Download
M content/renderer/media/media_stream_video_track_unittest.cc View 3 chunks +51 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Guido Urdaneta
3 years, 8 months ago (2017-04-20 08:41:14 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b249dd212dea164750205c689434d0341a9ad266.

Powered by Google App Engine
This is Rietveld 408576698