Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Issue 2827253004: Image Capture: set SENSOR_EXPOSURE_TIME when CONTROL_AE_MODE_OFF (Closed)

Created:
3 years, 8 months ago by mcasas
Modified:
3 years, 8 months ago
Reviewers:
scheib
CC:
chromium-reviews, posciak+watch_chromium.org, chfremer+watch_chromium.org, feature-media-reviews_chromium.org, agrieve+watch_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Image Capture: set SENSOR_EXPOSURE_TIME when CONTROL_AE_MODE_OFF This CL addresses a bug from the field: when the |exposureMode| is set to "manual", the camera abandons all AutoExposure and the captured image turns black, because the exposure time needs to be configured explicitly. The solution is to set it to the middle of the allowed range, leaving further configuration to the Iso (SENSOR_SENSITIVITY). BUG=713910 Review-Url: https://codereview.chromium.org/2827253004 Cr-Commit-Position: refs/heads/master@{#466350} Committed: https://chromium.googlesource.com/chromium/src/+/80d0234a6c13bba1e14ca76f48d7c437fe5b020e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
mcasas
scheib@ small CL, ptal
3 years, 8 months ago (2017-04-20 22:55:23 UTC) #2
scheib
lgtm
3 years, 8 months ago (2017-04-21 06:20:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827253004/1
3 years, 8 months ago (2017-04-21 14:47:04 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 15:57:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/80d0234a6c13bba1e14ca76f48d7...

Powered by Google App Engine
This is Rietveld 408576698