Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2827253003: [ObjC ARC] Converts ios/chrome/browser/ui/stack_view:perf_tests to ARC. (Closed)

Created:
3 years, 8 months ago by gambard
Modified:
3 years, 7 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/stack_view:perf_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2827253003 Cr-Commit-Position: refs/heads/master@{#468124} Committed: https://chromium.googlesource.com/chromium/src/+/fc2e2e83c42d118bdf3dfbd0afde6114205b9874

Patch Set 1 #

Patch Set 2 : Fix weak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -12 lines) Patch
M ios/chrome/browser/ui/stack_view/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/stack_view_controller_perftest.mm View 1 7 chunks +16 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
gambard
PTAL.
3 years, 8 months ago (2017-04-20 09:18:36 UTC) #4
gambard
ping
3 years, 7 months ago (2017-04-28 09:08:23 UTC) #5
kkhorimoto
lgtm
3 years, 7 months ago (2017-04-28 17:22:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827253003/20001
3 years, 7 months ago (2017-04-28 17:23:11 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 20:53:49 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fc2e2e83c42d118bdf3dfbd0afde...

Powered by Google App Engine
This is Rietveld 408576698