Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2827243004: [Payment Request] Adds a11y label resource IDs to the basic card data (Closed)

Created:
3 years, 8 months ago by Moe
Modified:
3 years, 8 months ago
Reviewers:
sebsg
CC:
chromium-reviews, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payment Request] Adds a11y label resource IDs to the basic card data BUG=602666 Review-Url: https://codereview.chromium.org/2827243004 Cr-Commit-Position: refs/heads/master@{#466344} Committed: https://chromium.googlesource.com/chromium/src/+/930b6e25d8cacb0b7f29fad35f99e8e060da38c8

Patch Set 1 #

Patch Set 2 : Fixed compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M components/autofill/core/browser/autofill_data_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_data_util.cc View 1 2 chunks +14 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Moe
Seb, Please take a look.
3 years, 8 months ago (2017-04-20 18:23:50 UTC) #2
sebsg
LGTM
3 years, 8 months ago (2017-04-20 19:20:04 UTC) #3
Moe
On 2017/04/20 19:20:04, sebsg wrote: > LGTM Thank you.
3 years, 8 months ago (2017-04-20 19:22:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827243004/1
3 years, 8 months ago (2017-04-20 19:23:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/252457) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 8 months ago (2017-04-20 19:49:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827243004/20001
3 years, 8 months ago (2017-04-21 14:27:42 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 15:33:13 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/930b6e25d8cacb0b7f29fad35f99...

Powered by Google App Engine
This is Rietveld 408576698