Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2827243003:
Use WaitForSwap in LayerWithRealCompositorTest.ReportMetrics (Closed)
DescriptionUse WaitForSwap in LayerWithRealCompositorTest.ReportMetrics
Replace WaitForDraw with WaitForSwap in
LayerWithRealCompositorTest.ReportMetrics since WaitForDraw causes the test to
be flaky.
BUG=709080
TBR=danakj@chromium.org
Review-Url: https://codereview.chromium.org/2827243003
Cr-Commit-Position: refs/heads/master@{#465986}
Committed: https://chromium.googlesource.com/chromium/src/+/349c2bfb9b604092ff8c4a78752cc7e25a1fca34
Patch Set 1 #
Total comments: 2
Patch Set 2 : Reenable the LayerWithRealCompositorTest.ReportMetrics on Windows #Messages
Total messages: 18 (9 generated)
staraz@chromium.org changed reviewers: + danakj@chromium.org
PTAL.
Description was changed from ========== Use WaitForSwap in LayerWithRealCompositorTest.ReportMetrics Replace WaitForDraw with WaitForSwap in LayerWithRealCompositorTest.ReportMetrics since WaitForDraw causes the test to be flaky. BUG=709080 ========== to ========== Use WaitForSwap in LayerWithRealCompositorTest.ReportMetrics Replace WaitForDraw with WaitForSwap in LayerWithRealCompositorTest.ReportMetrics since WaitForDraw causes the test to be flaky. BUG=709080 TBR=danakj@chromium.org ==========
The CQ bit was checked by staraz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
fsamuel@chromium.org changed reviewers: + fsamuel@chromium.org
lgtm
The CQ bit was checked by staraz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1492691388278480, "parent_rev":
"a47740436146174ce74fca4fcbcf9b2b92c8e355", "commit_rev":
"349c2bfb9b604092ff8c4a78752cc7e25a1fca34"}
Message was sent while issue was closed.
Description was changed from ========== Use WaitForSwap in LayerWithRealCompositorTest.ReportMetrics Replace WaitForDraw with WaitForSwap in LayerWithRealCompositorTest.ReportMetrics since WaitForDraw causes the test to be flaky. BUG=709080 TBR=danakj@chromium.org ========== to ========== Use WaitForSwap in LayerWithRealCompositorTest.ReportMetrics Replace WaitForDraw with WaitForSwap in LayerWithRealCompositorTest.ReportMetrics since WaitForDraw causes the test to be flaky. BUG=709080 TBR=danakj@chromium.org Review-Url: https://codereview.chromium.org/2827243003 Cr-Commit-Position: refs/heads/master@{#465986} Committed: https://chromium.googlesource.com/chromium/src/+/349c2bfb9b604092ff8c4a78752c... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/349c2bfb9b604092ff8c4a78752c...
Message was sent while issue was closed.
https://codereview.chromium.org/2827243003/diff/1/ui/compositor/layer_unittes... File ui/compositor/layer_unittest.cc (right): https://codereview.chromium.org/2827243003/diff/1/ui/compositor/layer_unittes... ui/compositor/layer_unittest.cc:2212: #if defined(OS_WIN) Should it be enabled on windows now?
Message was sent while issue was closed.
Description was changed from ========== Use WaitForSwap in LayerWithRealCompositorTest.ReportMetrics Replace WaitForDraw with WaitForSwap in LayerWithRealCompositorTest.ReportMetrics since WaitForDraw causes the test to be flaky. BUG=709080 TBR=danakj@chromium.org Review-Url: https://codereview.chromium.org/2827243003 Cr-Commit-Position: refs/heads/master@{#465986} Committed: https://chromium.googlesource.com/chromium/src/+/349c2bfb9b604092ff8c4a78752c... ========== to ========== Use WaitForSwap in LayerWithRealCompositorTest.ReportMetrics Replace WaitForDraw with WaitForSwap in LayerWithRealCompositorTest.ReportMetrics since WaitForDraw causes the test to be flaky. BUG=709080 TBR=danakj@chromium.org Review-Url: https://codereview.chromium.org/2827243003 Cr-Commit-Position: refs/heads/master@{#465986} Committed: https://chromium.googlesource.com/chromium/src/+/349c2bfb9b604092ff8c4a78752c... ==========
https://codereview.chromium.org/2827243003/diff/1/ui/compositor/layer_unittes... File ui/compositor/layer_unittest.cc (right): https://codereview.chromium.org/2827243003/diff/1/ui/compositor/layer_unittes... ui/compositor/layer_unittest.cc:2212: #if defined(OS_WIN) On 2017/04/20 13:46:31, danakj wrote: > Should it be enabled on windows now? Done.
On 2017/04/20 13:54:00, Alex Z. wrote: > https://codereview.chromium.org/2827243003/diff/1/ui/compositor/layer_unittes... > File ui/compositor/layer_unittest.cc (right): > > https://codereview.chromium.org/2827243003/diff/1/ui/compositor/layer_unittes... > ui/compositor/layer_unittest.cc:2212: #if defined(OS_WIN) > On 2017/04/20 13:46:31, danakj wrote: > > Should it be enabled on windows now? > > Done. You'll have to open another CL unless you want to revert this one. |
