Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2827183002: Merge "SELECT popup: Fix OPTGROUP rendering on a device with a touch-screen." to M59 (Closed)

Created:
3 years, 8 months ago by tkent
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Merge "SELECT popup: Fix OPTGROUP rendering on a device with a touch-screen." to M59 We should not apply display:flex to OPTGROUP elements in popups. BUG=712107 Review-Url: https://codereview.chromium.org/2824123002 Cr-Commit-Position: refs/heads/master@{#465174} (cherry picked from commit db9cef9964f34067223f3d95f8a0206a3d07254b) Review-Url: https://codereview.chromium.org/2827183002 . Cr-Commit-Position: refs/branch-heads/3071@{#75} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/4c079a58c05a2b03aca24fdcfae77bcb5c7ceeb0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-appearance-coarse.html View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/forms/select-popup/popup-menu-appearance-coarse-expected.png View Binary file 0 comments Download
M third_party/WebKit/Source/web/PopupMenuImpl.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tkent
3 years, 8 months ago (2017-04-20 00:55:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4c079a58c05a2b03aca24fdcfae77bcb5c7ceeb0.

Powered by Google App Engine
This is Rietveld 408576698