Updating session related code to integrate with client code.

This cl connects a dummy pin to the session delegate in order to test out the connection authentication flow.

BUG=671692
Review-Url: https://codereview.chromium.org/2827163004
Cr-Commit-Position: refs/heads/master@{#466485}
Committed: https://chromium.googlesource.com/chromium/src/+/b31d544a5feacdf41081c52d61cacc5cb5bc10ae

[nicholss, 2017-04-19 23:41:14]

The CQ bit was checked by nicholss@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 23:41:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 00:56:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 00:56:08]

Dry run: This issue passed the CQ dry run.

[nicholss, 2017-04-21 16:49:31]

The CQ bit was checked by nicholss@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 16:49:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nicholss, 2017-04-21 17:01:39]

The CQ bit was checked by nicholss@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 17:02:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nicholss, 2017-04-21 17:22:57]

nicholss@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[nicholss, 2017-04-21 17:22:58]

PTAL, here are changes need to integrate client session into iOS.

[commit-bot: I haz the power, 2017-04-21 18:14:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 18:14:16]

Dry run: This issue passed the CQ dry run.

[nicholss, 2017-04-21 21:25:40]

nicholss@chromium.org changed reviewers:
+ yuweih@chromium.org

[nicholss, 2017-04-21 21:25:41]

PTAL?

[Yuwei, 2017-04-21 21:33:39]

LGTM

https://codereview.chromium.org/2827163004/diff/40001/remoting/client/ios/ses...
File remoting/client/ios/session/BUILD.gn (right):

https://codereview.chromium.org/2827163004/diff/40001/remoting/client/ios/ses...
remoting/client/ios/session/BUILD.gn:9: source_set("session") {
Hmm... It seems like this target is not building/used by ios_remoting_app yet?

[nicholss, 2017-04-21 21:43:29]

On 2017/04/21 21:33:39, Yuwei wrote:
> LGTM
> 
>
https://codereview.chromium.org/2827163004/diff/40001/remoting/client/ios/ses...
> File remoting/client/ios/session/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2827163004/diff/40001/remoting/client/ios/ses...
> remoting/client/ios/session/BUILD.gn:9: source_set("session") {
> Hmm... It seems like this target is not building/used by ios_remoting_app yet?

It is used in ios_core in the root ios directory.

[nicholss, 2017-04-21 21:43:43]

The CQ bit was checked by nicholss@chromium.org

[commit-bot: I haz the power, 2017-04-21 21:44:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 21:53:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 21:53:18]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Jamie, 2017-04-21 23:04:29]

lgtm

Can you provide a bit more detail in the description? The only things this CL
seems to do is move some code onto a different thread and return a dummy PIN.

If that's correct then LGTM, but please state it in the CL description.

[nicholss, 2017-04-21 23:06:58]

Description was changed from

==========
Updating session related code to integrate with client code.

BUG=671692
==========

to

==========
This cl connects a dummy pin to the session delegate in order to test out the
connection authentication flow.

BUG=671692
==========

[nicholss, 2017-04-21 23:07:03]

The CQ bit was checked by nicholss@chromium.org

[commit-bot: I haz the power, 2017-04-21 23:07:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 23:12:12]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492816023777900,
"parent_rev": "1cbb0dbc2bf92e801b813cc088b3d9646887019c", "commit_rev":
"b31d544a5feacdf41081c52d61cacc5cb5bc10ae"}

[commit-bot: I haz the power, 2017-04-21 23:12:30]

Description was changed from

==========
This cl connects a dummy pin to the session delegate in order to test out the
connection authentication flow.

BUG=671692
==========

to

==========
This cl connects a dummy pin to the session delegate in order to test out the
connection authentication flow.

BUG=671692

Review-Url: https://codereview.chromium.org/2827163004
Cr-Commit-Position: refs/heads/master@{#466485}
Committed:
https://chromium.googlesource.com/chromium/src/+/b31d544a5feacdf41081c52d61ca...
==========

[commit-bot: I haz the power, 2017-04-21 23:12:31]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b31d544a5feacdf41081c52d61ca...