[Payment Request] Improved matching for the UIAlertView in showcase egtests

[Payment Request] Improved matching for the UIAlertView in showcase egtests

BUG=602666
Review-Url: https://codereview.chromium.org/2827163002
Cr-Commit-Position: refs/heads/master@{#466066}
Committed: https://chromium.googlesource.com/chromium/src/+/3028564df614bd9c3b0d5abb150d95f0d6b74d71

[Moe, 2017-04-19 22:37:52]

Patchset #1 (id:1) has been deleted

[Moe, 2017-04-19 22:40:50]

mahmadi@chromium.org changed reviewers:
+ lpromero@chromium.org

[Moe, 2017-04-19 22:40:51]

Hi Louis, Please take a look.

https://codereview.chromium.org/2827163002/diff/20001/ios/chrome/browser/ui/c...
File ios/chrome/browser/ui/collection_view/collection_view_controller.mm
(right):

https://codereview.chromium.org/2827163002/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/collection_view/collection_view_controller.mm:267: -
(NSString*)description {
UITableViewController seems to be already overriding this, but not
UICollectionViewController.

[lpromero, 2017-04-20 16:28:49]

lgtm

https://codereview.chromium.org/2827163002/diff/20001/ios/chrome/browser/ui/c...
File ios/chrome/browser/ui/collection_view/collection_view_controller.mm
(right):

https://codereview.chromium.org/2827163002/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/collection_view/collection_view_controller.mm:267: -
(NSString*)description {
On 2017/04/19 22:40:51, moe wrote:
> UITableViewController seems to be already overriding this, but not
> UICollectionViewController. 

Why do you need this? And why in the context of this CL? (Might be the same
answer for both questions :p)

[Moe, 2017-04-20 17:44:52]

Thank you.

https://codereview.chromium.org/2827163002/diff/20001/ios/chrome/browser/ui/c...
File ios/chrome/browser/ui/collection_view/collection_view_controller.mm
(right):

https://codereview.chromium.org/2827163002/diff/20001/ios/chrome/browser/ui/c...
ios/chrome/browser/ui/collection_view/collection_view_controller.mm:267: -
(NSString*)description {
On 2017/04/20 16:28:49, lpromero wrote:
> On 2017/04/19 22:40:51, moe wrote:
> > UITableViewController seems to be already overriding this, but not
> > UICollectionViewController. 
> 
> Why do you need this? And why in the context of this CL? (Might be the same
> answer for both questions :p)

The difference would be:
http://imgur.com/a/SEepa vs http://imgur.com/a/NzXTv
Without overriding the description i'd have to write my own matcher that does
partial string matching.
The reason I brought up the UITableViewController was that I noticed that the
PaymentsPickerViewController already has this behavior:
http://imgur.com/a/4v9B8

[Moe, 2017-04-20 17:44:57]

The CQ bit was checked by mahmadi@chromium.org

[commit-bot: I haz the power, 2017-04-20 17:45:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 17:59:51]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492710297128490,
"parent_rev": "5895ccc48d4395a1b5359a6ca8ca9eb654d4cd3d", "commit_rev":
"3028564df614bd9c3b0d5abb150d95f0d6b74d71"}

[commit-bot: I haz the power, 2017-04-20 18:00:04]

Description was changed from

==========
[Payment Request] Improved matching for the UIAlertView in showcase egtests

BUG=602666
==========

to

==========
[Payment Request] Improved matching for the UIAlertView in showcase egtests

BUG=602666

Review-Url: https://codereview.chromium.org/2827163002
Cr-Commit-Position: refs/heads/master@{#466066}
Committed:
https://chromium.googlesource.com/chromium/src/+/3028564df614bd9c3b0d5abb150d...
==========

[commit-bot: I haz the power, 2017-04-20 18:00:05]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3028564df614bd9c3b0d5abb150d...