Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 2827123007: Ignore negative cadence values. (Closed)

Created:
3 years, 8 months ago by DaleCurtis
Modified:
3 years, 8 months ago
Reviewers:
qiangchen
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Ignore negative cadence values. BUG=713826 TEST=clusterfuzz test case no longer check fails. Review-Url: https://codereview.chromium.org/2827123007 Cr-Commit-Position: refs/heads/master@{#466478} Committed: https://chromium.googlesource.com/chromium/src/+/74ea768c1be4f0c38700d7cb7e30d6ba03ca973a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M media/filters/video_cadence_estimator.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
DaleCurtis
3 years, 8 months ago (2017-04-21 00:12:14 UTC) #2
qiangchen
On 2017/04/21 00:12:14, DaleCurtis wrote: Are you sure this could fix the issue? From my ...
3 years, 8 months ago (2017-04-21 16:32:42 UTC) #3
DaleCurtis
You can build and run the sample and it'll fail locally, instrumention shows its because ...
3 years, 8 months ago (2017-04-21 16:38:35 UTC) #4
qiangchen
lgtm
3 years, 8 months ago (2017-04-21 20:29:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827123007/1
3 years, 8 months ago (2017-04-21 20:32:25 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 22:44:38 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/74ea768c1be4f0c38700d7cb7e30...

Powered by Google App Engine
This is Rietveld 408576698