When we open a popup window from an app window, we used to identify this popu...

When we open a popup window from an app window, we used to identify this popup window as an app too.

To not lose this functionality, yet fix bug 5739 about those app popup windows which would persist their window placement, I decided to add a new enum browser type item which is a bit combination of both popup and app so we can track those.

bug= http://crbug.com/5739


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10636

[MAD, 2009-02-27 21:51:03]

Feel free to redirect to someone else if more appropriate...

Thanks!

BYE
MAD

[Ben Goodger (Google), 2009-02-27 21:55:08]

LGTM.

http://codereview.chromium.org/28271/diff/1/3
File chrome/browser/browser.h (right):

http://codereview.chromium.org/28271/diff/1/3#newcode57
Line 57: TYPE_POPUP_APP = TYPE_APP | TYPE_POPUP,
TYPE_APP_POPUP reads better to me.

http://codereview.chromium.org/28271/diff/1/3#newcode78
Line 78: bool popup);
is_popup

[MAD, 2009-02-27 22:03:46]

Thanks... That was quick!!!

http://codereview.chromium.org/28271/diff/1/3
File chrome/browser/browser.h (right):

http://codereview.chromium.org/28271/diff/1/3#newcode57
Line 57: TYPE_POPUP_APP = TYPE_APP | TYPE_POPUP,
On 2009/02/27 21:55:08, Ben Goodger wrote:
> TYPE_APP_POPUP reads better to me.

Done.
I actually thought popup_app sounded funnier...
But I'm easy... :-)

http://codereview.chromium.org/28271/diff/1/3#newcode78
Line 78: bool popup);
On 2009/02/27 21:55:08, Ben Goodger wrote:
> is_popup

Done.