Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3890)

Unified Diff: chrome/browser/browser.h

Issue 28271: When we open a popup window from an app window, we used to identify this popu... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/browser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser.h
===================================================================
--- chrome/browser/browser.h (revision 10620)
+++ chrome/browser/browser.h (working copy)
@@ -53,7 +53,8 @@
enum Type {
TYPE_NORMAL = 0,
TYPE_POPUP = 1,
- TYPE_APP = 2
+ TYPE_APP = 2,
+ TYPE_APP_POPUP = TYPE_APP | TYPE_POPUP,
};
// Constructors, Creation, Showing //////////////////////////////////////////
@@ -72,8 +73,9 @@
static Browser* CreateForPopup(Profile* profile);
// Like Create, but creates a tabstrip-less and toolbar-less "app" window for
- // the specified app.
- static Browser* CreateForApp(const std::wstring& app_name, Profile* profile);
+ // the specified app. Passing popup=true will create a TYPE_APP_POPUP browser
+ static Browser* CreateForApp(const std::wstring& app_name, Profile* profile,
+ bool is_popup);
// Set overrides for the initial window bounds and maximized state.
void set_override_bounds(const gfx::Rect& bounds) {
« no previous file with comments | « no previous file | chrome/browser/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698