Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2827023003: Add substitute_tmpl.grd to translation_expectations.pyl. (Closed)

Created:
3 years, 8 months ago by slan
Modified:
3 years, 8 months ago
Reviewers:
dimu, Nico
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add substitute_tmpl.grd to translation_expectations.pyl. This is a test file, and should be whitelisted from translation. Introduced in this CL: https://codereview.chromium.org/2802853003 BUG=711550 Review-Url: https://codereview.chromium.org/2827023003 Cr-Commit-Position: refs/heads/master@{#465798} Committed: https://chromium.googlesource.com/chromium/src/+/d81362531b4bf2904a57385292f6e3dbc152963e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/gritsettings/translation_expectations.pyl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
slan
+thakis for OWNERS +dimu, +govind for FYI PTAL! Perhaps we should check in this script ...
3 years, 8 months ago (2017-04-19 19:40:26 UTC) #2
dimu
lgtm
3 years, 8 months ago (2017-04-19 19:49:51 UTC) #4
Nico
lgtm
3 years, 8 months ago (2017-04-19 20:09:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827023003/1
3 years, 8 months ago (2017-04-19 22:53:45 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 23:01:15 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d81362531b4bf2904a57385292f6...

Powered by Google App Engine
This is Rietveld 408576698