CSS Motion Path: delete implementation of motion-path property

CSS Motion Path: delete implementation of motion-path property

The 'motion-path' property has been replaced by 'offset-path'.

'motion-path' is among the properties disabled in M58.

BUG=711937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2827003002
Cr-Commit-Position: refs/heads/master@{#467605}
Committed: https://chromium.googlesource.com/chromium/src/+/cbe00006cf35aa25a33e45c6ad8cd68ddf774cb8

[Eric Willigers, 2017-04-19 12:47:15]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[Eric Willigers, 2017-04-19 12:47:29]

ericwilligers@chromium.org changed reviewers:
+ bugsnash@chromium.org

[commit-bot: I haz the power, 2017-04-19 12:47:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 14:05:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 14:05:52]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Eric Willigers, 2017-04-20 00:29:18]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 00:29:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 01:34:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 01:34:46]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Bugs Nash, 2017-04-20 04:44:55]

On 2017/04/19 at 12:47:29, ericwilligers wrote:
> 

There are a couple more uses of motion-path throughout the code base that you
might wanna remove (or perhaps add code comments or CL description comments as
to why they're still being used)

LayoutTest: animations/interpolation/motion-offset-interpolation.html
ManualTests: animation/compositor-transform-prevented-by-motion-path.html and
animation/compositor-transform-fill-forwards-with-motion-path.html
unit test: core/paint/PaintPropertyTreeBuilderTest.cpp

Also 2 files outside of Webkit apparently? I guess those can be ignored.
src/tools/metrics/histograms/histograms.xml and
infra/appengine/third_party/npm_modules/polymer_0.4.0/bower_components/web-animations-js/test/testcases.js

[Bugs Nash, 2017-04-20 04:45:11]

https://codereview.chromium.org/2827003002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/css3/motion-path/motion-properties-deprecated-expected.txt
(left):

https://codereview.chromium.org/2827003002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/css3/motion-path/motion-properties-deprecated-expected.txt:2:
CONSOLE WARNING: motion-path is deprecated and will be removed in M58, around
April 2017. Please use offset-path instead. See
https://www.chromestatus.com/features/6390764217040896 for more details.
should motion-offset be removed from the test entirely? that wouldn't be a good
test to make sure this console warning doesn't appear anymore, but it feels
weird to leave usage of a property that doesn't exist

https://codereview.chromium.org/2827003002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/2827003002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:761: static
CSSValue* ConsumeOffsetPath(CSSParserTokenRange& range,
this has been moved to CSSPropertyOffsetPathUtils so needs a rebase

[Eric Willigers, 2017-04-26 01:25:35]

Description was changed from

==========
CSS Motion Path: delete implementation of motion-path property

The 'motion-path' property has been replaced by 'offset-path'.

'motion-path' is among the properties disabled in M58.

BUG=711937
==========

to

==========
CSS Motion Path: delete implementation of motion-path property

The 'motion-path' property has been replaced by 'offset-path'.

'motion-path' is among the properties disabled in M58.

BUG=711937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Eric Willigers, 2017-04-26 01:26:57]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[Eric Willigers, 2017-04-26 01:27:10]

https://codereview.chromium.org/2827003002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/css3/motion-path/motion-properties-deprecated-expected.txt
(left):

https://codereview.chromium.org/2827003002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/css3/motion-path/motion-properties-deprecated-expected.txt:2:
CONSOLE WARNING: motion-path is deprecated and will be removed in M58, around
April 2017. Please use offset-path instead. See
https://www.chromestatus.com/features/6390764217040896 for more details.
On 2017/04/20 04:45:11, Bugs Nash wrote:
> should motion-offset be removed from the test entirely? that wouldn't be a
good
> test to make sure this console warning doesn't appear anymore, but it feels
> weird to leave usage of a property that doesn't exist

Done.

https://codereview.chromium.org/2827003002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/2827003002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:761: static
CSSValue* ConsumeOffsetPath(CSSParserTokenRange& range,
On 2017/04/20 04:45:11, Bugs Nash wrote:
> this has been moved to CSSPropertyOffsetPathUtils so needs a rebase

Acknowledged.

[commit-bot: I haz the power, 2017-04-26 01:27:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 03:20:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 03:20:23]

Dry run: This issue passed the CQ dry run.

[Bugs Nash, 2017-04-26 07:18:43]

On 2017/04/26 at 01:27:10, ericwilligers wrote:
>
https://codereview.chromium.org/2827003002/diff/1/third_party/WebKit/LayoutTe...
> File
third_party/WebKit/LayoutTests/css3/motion-path/motion-properties-deprecated-expected.txt
(left):
> 
>
https://codereview.chromium.org/2827003002/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/css3/motion-path/motion-properties-deprecated-expected.txt:2:
CONSOLE WARNING: motion-path is deprecated and will be removed in M58, around
April 2017. Please use offset-path instead. See
https://www.chromestatus.com/features/6390764217040896 for more details.
> On 2017/04/20 04:45:11, Bugs Nash wrote:
> > should motion-offset be removed from the test entirely? that wouldn't be a
good
> > test to make sure this console warning doesn't appear anymore, but it feels
> > weird to leave usage of a property that doesn't exist
> 
> Done.
> 
>
https://codereview.chromium.org/2827003002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):
> 
>
https://codereview.chromium.org/2827003002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:761: static
CSSValue* ConsumeOffsetPath(CSSParserTokenRange& range,
> On 2017/04/20 04:45:11, Bugs Nash wrote:
> > this has been moved to CSSPropertyOffsetPathUtils so needs a rebase
> 
> Acknowledged.


I see that you removed the use of motion-path from
PaintPropertyTreeBuilderTest.cpp as per my previous comment but not from the
layout test and manual tests I mentioned. Is there a reason for this?

[Eric Willigers, 2017-04-27 00:02:38]

On 2017/04/26 07:18:43, Bugs Nash wrote:
> On 2017/04/26 at 01:27:10, ericwilligers wrote:
> >
>
https://codereview.chromium.org/2827003002/diff/1/third_party/WebKit/LayoutTe...
> > File
>
third_party/WebKit/LayoutTests/css3/motion-path/motion-properties-deprecated-expected.txt
> (left):
> > 
> >
>
https://codereview.chromium.org/2827003002/diff/1/third_party/WebKit/LayoutTe...
> >
>
third_party/WebKit/LayoutTests/css3/motion-path/motion-properties-deprecated-expected.txt:2:
> CONSOLE WARNING: motion-path is deprecated and will be removed in M58, around
> April 2017. Please use offset-path instead. See
> https://www.chromestatus.com/features/6390764217040896 for more details.
> > On 2017/04/20 04:45:11, Bugs Nash wrote:
> > > should motion-offset be removed from the test entirely? that wouldn't be a
> good
> > > test to make sure this console warning doesn't appear anymore, but it
feels
> > > weird to leave usage of a property that doesn't exist
> > 
> > Done.
> > 
> >
>
https://codereview.chromium.org/2827003002/diff/1/third_party/WebKit/Source/c...
> > File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
(right):
> > 
> >
>
https://codereview.chromium.org/2827003002/diff/1/third_party/WebKit/Source/c...
> > third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:761: static
> CSSValue* ConsumeOffsetPath(CSSParserTokenRange& range,
> > On 2017/04/20 04:45:11, Bugs Nash wrote:
> > > this has been moved to CSSPropertyOffsetPathUtils so needs a rebase
> > 
> > Acknowledged.
> 
> 
> I see that you removed the use of motion-path from
> PaintPropertyTreeBuilderTest.cpp as per my previous comment but not from the
> layout test and manual tests I mentioned. Is there a reason for this?

Sorry, I missed your first comment. PaintPropertyTreeBuilderTest.cpp was
independently noticed by a try job failure.

The first 4 files you mention are now fixed. We keep the entry in
histograms.xml as old versions of Chrome still report usage of the property.
polymer_0.4.0 is very old. No need for us to touch it.

[Bugs Nash, 2017-04-27 00:08:56]

lgtm! 14 insertions, 123 deletions \o/ hooray for deleting code!!!

[Eric Willigers, 2017-04-27 00:20:22]

ericwilligers@chromium.org changed reviewers:
+ rbyers@chromium.org

[Eric Willigers, 2017-04-27 00:20:23]

+rbyers for OWNERS. This is the 2nd of 5 patches for properties retired in M58.

[Eric Willigers, 2017-04-27 03:29:20]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 03:29:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eric Willigers, 2017-04-27 03:30:53]

ericwilligers@chromium.org changed reviewers:
+ meade@chromium.org

[Eric Willigers, 2017-04-27 03:30:54]

Adding Eddy for OWNER review.

[commit-bot: I haz the power, 2017-04-27 05:40:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 05:40:57]

Dry run: This issue passed the CQ dry run.

[meade_UTC10, 2017-04-27 06:18:40]

lgtm

\o/ Yay deleting things!

[Eric Willigers, 2017-04-27 06:24:13]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2017-04-27 06:24:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 06:30:03]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493274253022550,
"parent_rev": "ef74ec9973e071da2dc5813f0b93662a0f1497bf", "commit_rev":
"cbe00006cf35aa25a33e45c6ad8cd68ddf774cb8"}

[commit-bot: I haz the power, 2017-04-27 06:30:13]

Description was changed from

==========
CSS Motion Path: delete implementation of motion-path property

The 'motion-path' property has been replaced by 'offset-path'.

'motion-path' is among the properties disabled in M58.

BUG=711937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
CSS Motion Path: delete implementation of motion-path property

The 'motion-path' property has been replaced by 'offset-path'.

'motion-path' is among the properties disabled in M58.

BUG=711937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2827003002
Cr-Commit-Position: refs/heads/master@{#467605}
Committed:
https://chromium.googlesource.com/chromium/src/+/cbe00006cf35aa25a33e45c6ad8c...
==========

[commit-bot: I haz the power, 2017-04-27 06:30:14]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cbe00006cf35aa25a33e45c6ad8c...