Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Issue 2826943002: Rewrite base::Bind to base::BindOnce with base_bind_rewriters in //chrome/browser/sync_file_system (Closed)

Created:
3 years, 8 months ago by tzik
Modified:
3 years, 8 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrite base::Bind to base::BindOnce with base_bind_rewriters in //chrome/browser/sync_file_system This is a generated CL by a clang refactoring tool at //tools/clang/base_bind_rewriters. The tool rewrites base::Bind to base::BindOnce where the resulting Callback is immediately converted to OnceCallback. E.g.: base::PostTask(FROM_HERE, base::Bind(&Foo)); is rewritten to: base::PostTask(FROM_HERE, base::BindOnce(&Foo)); In terms of the behavior change after the rewrite, the OnceCallback implementation moves out the bound argument to the target function, unlike Callback. BUG=554299 Review-Url: https://codereview.chromium.org/2826943002 Cr-Commit-Position: refs/heads/master@{#465834} Committed: https://chromium.googlesource.com/chromium/src/+/616af64093de539709fe6be5085029a42e58fe2d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -362 lines) Patch
M chrome/browser/sync_file_system/drive_backend/callback_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_service_on_worker.cc View 11 chunks +47 lines, -64 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_uploader_on_worker.cc View 2 chunks +9 lines, -17 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/fake_drive_uploader.cc View 2 chunks +3 lines, -10 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/remote_change_processor_on_worker.cc View 4 chunks +17 lines, -24 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine.cc View 19 chunks +51 lines, -78 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_task_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_task_manager_unittest.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_worker.cc View 2 chunks +6 lines, -10 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_worker_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/fake_remote_change_processor.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/local/canned_syncable_file_system.cc View 6 chunks +18 lines, -19 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_context.cc View 27 chunks +68 lines, -71 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_context_unittest.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_service_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/local/root_delete_helper.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/local/sync_file_system_backend.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/mock_local_change_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/mock_remote_file_sync_service.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service_unittest.cc View 3 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
tzik
PTAL
3 years, 8 months ago (2017-04-19 13:33:09 UTC) #6
nhiroki
lgtm
3 years, 8 months ago (2017-04-19 23:17:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826943002/1
3 years, 8 months ago (2017-04-20 00:46:46 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 00:53:16 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/616af64093de539709fe6be50850...

Powered by Google App Engine
This is Rietveld 408576698