Issue 282693002: Add a null check for PermissionBubbleManager::FromWebcontents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 282693002: Add a null check for PermissionBubbleManager::FromWebcontents. (Closed)

Created:
6 years, 7 months ago by leng

Modified:
6 years, 7 months ago

Reviewers:
gbillock, Greg Billock

CC:
chromium-reviews, fischman+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org, Michael van Ouwerkerk

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Add a null check for PermissionBubbleManager::FromWebcontents. There is a small chance that the permission bubble manager for a given web contents has been deleted before an asychronous permission request has been handled. BUG=371085 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269987

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -21 lines)			Patch
M	chrome/browser/chrome_quota_permission_context.cc	View	1 chunk	+7 lines, -5 lines	0 comments	Download
M	chrome/browser/geolocation/chrome_geolocation_permission_context.cc	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/media/chrome_midi_permission_context.cc	View	1 chunk	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/media/media_capture_devices_dispatcher.cc	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/notifications/desktop_notification_service.cc	View	1 chunk	+8 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leng@chromium.org/282693002/1

6 years, 7 months ago (2014-05-12 23:02:15 UTC) #4

Message was sent while issue was closed.

Change committed as 269987

Expand Messages | Collapse Messages