chrome/browser/media/chrome_midi_permission_context.cc - Issue 282693002: Add a null check for PermissionBubbleManager::FromWebcontents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/chrome_midi_permission_context.cc

Issue 282693002: Add a null check for PermissionBubbleManager::FromWebcontents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/geolocation/chrome_geolocation_permission_context.cc ('k') | chrome/browser/media/media_capture_devices_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/chrome_midi_permission_context.cc

diff --git a/chrome/browser/media/chrome_midi_permission_context.cc b/chrome/browser/media/chrome_midi_permission_context.cc

index 657b2653d67d44440e0c1e1a4efab85de865ecda..223609ad9425d865a03c714459a49fe40b143e86 100644

--- a/chrome/browser/media/chrome_midi_permission_context.cc

+++ b/chrome/browser/media/chrome_midi_permission_context.cc

@@ -199,10 +199,12 @@ void ChromeMidiPermissionContext::DecidePermission(

if (PermissionBubbleManager::Enabled()) {

PermissionBubbleManager* bubble_manager =

PermissionBubbleManager::FromWebContents(web_contents);

- bubble_manager->AddRequest(new MidiPermissionRequest(

- this, id, requesting_frame, user_gesture,

- profile_->GetPrefs()->GetString(prefs::kAcceptLanguages),

- callback));

+ if (bubble_manager) {

+ bubble_manager->AddRequest(new MidiPermissionRequest(

+ this, id, requesting_frame, user_gesture,

+ profile_->GetPrefs()->GetString(prefs::kAcceptLanguages),

+ callback));

+ }

return;

}