Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2826923002: Replace ASSERT and ASSERT_NOT_REACHED in third_party/Webkit/public (Closed)

Created:
3 years, 8 months ago by Hwanseung Lee
Modified:
3 years, 8 months ago
Reviewers:
tkent, haraken
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ASSERT and ASSERT_NOT_REACHED in third_party/Webkit/public Replace ASSERT and ASSERT_NOT_REACHED with DCHECK_op, and NOTREACHED respectively in third_party/WebKit/public. BUG=708057 Review-Url: https://codereview.chromium.org/2826923002 Cr-Commit-Position: refs/heads/master@{#465533} Committed: https://chromium.googlesource.com/chromium/src/+/845b88e690815e8e57e8bc5505d4ac1b0295c20e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/public/platform/WebPrivatePtr.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebTextDirection.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
Hwanseung Lee
PTAL, thank you.
3 years, 8 months ago (2017-04-19 06:58:23 UTC) #5
haraken
LGTM
3 years, 8 months ago (2017-04-19 07:22:51 UTC) #6
tkent
lgtm
3 years, 8 months ago (2017-04-19 08:37:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826923002/1
3 years, 8 months ago (2017-04-19 08:37:21 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 08:41:44 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/845b88e690815e8e57e8bc5505d4...

Powered by Google App Engine
This is Rietveld 408576698