Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2826903002: [ES6 modules] Integrate ModuleTreeLinkerRegistry into ModulatorImpl back-plane (Closed)

Created:
3 years, 8 months ago by kouhei (in TOK)
Modified:
3 years, 8 months ago
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis, module-dev_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ES6 modules] Integrate ModuleTreeLinkerRegistry into ModulatorImpl back-plane This CL plumbs ModulatorImpl::FetchTreeInternal() to its algorithm implementation ModuleTreeLinker{,Registry}. BUG=594639 Review-Url: https://codereview.chromium.org/2826903002 Cr-Commit-Position: refs/heads/master@{#465799} Committed: https://chromium.googlesource.com/chromium/src/+/b985210b2afe0d77382b6cf818aaee56968b0e6f

Patch Set 1 #

Patch Set 2 : create/trace #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M third_party/WebKit/Source/core/dom/ModulatorImpl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ModulatorImpl.cpp View 1 4 chunks +4 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (14 generated)
kouhei (in TOK)
3 years, 8 months ago (2017-04-19 05:09:33 UTC) #2
yhirano
lgtm
3 years, 8 months ago (2017-04-19 06:21:37 UTC) #6
nhiroki
lgtm
3 years, 8 months ago (2017-04-19 06:24:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826903002/40001
3 years, 8 months ago (2017-04-19 13:05:52 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/275235)
3 years, 8 months ago (2017-04-19 14:33:54 UTC) #16
hiroshige
On 2017/04/19 14:33:54, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 8 months ago (2017-04-19 21:27:11 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826903002/40001
3 years, 8 months ago (2017-04-19 21:28:11 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 23:03:45 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b985210b2afe0d77382b6cf818aa...

Powered by Google App Engine
This is Rietveld 408576698