Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1132)

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollableArea.h

Issue 2826893003: Remove ScrollableArea::GetFrameViewBase and move ScheduleAnimation into subclasses. (Closed)
Patch Set: Remove UNREACHED Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scroll/ScrollableArea.h
diff --git a/third_party/WebKit/Source/platform/scroll/ScrollableArea.h b/third_party/WebKit/Source/platform/scroll/ScrollableArea.h
index eaa0172ec6fde8fffbea30891128ca7eafac410f..b2e951eb5af5700be1fa892d56a89c09673e6bfa 100644
--- a/third_party/WebKit/Source/platform/scroll/ScrollableArea.h
+++ b/third_party/WebKit/Source/platform/scroll/ScrollableArea.h
@@ -261,7 +261,7 @@ class PLATFORM_EXPORT ScrollableArea : public GarbageCollectedMixin,
// Let subclasses provide a way of asking for and servicing scroll
// animations.
- virtual bool ScheduleAnimation();
+ virtual bool ScheduleAnimation() { return false; }
virtual void ServiceScrollAnimations(double monotonic_time);
virtual void UpdateCompositorScrollAnimations();
virtual void RegisterForAnimation() {}
@@ -341,9 +341,6 @@ class PLATFORM_EXPORT ScrollableArea : public GarbageCollectedMixin,
virtual int HorizontalScrollbarHeight(
OverlayScrollbarClipBehavior = kIgnorePlatformOverlayScrollbarSize) const;
- // Returns the widget associated with this ScrollableArea.
- virtual FrameViewBase* GetFrameViewBase() { return nullptr; }
-
virtual LayoutBox* GetLayoutBox() const { return nullptr; }
// Maps a quad from the coordinate system of a LayoutObject contained by the

Powered by Google App Engine
This is Rietveld 408576698