third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp - Issue 2826893003: Remove ScrollableArea::GetFrameViewBase and move ScheduleAnimation into subclasses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp

Issue 2826893003: Remove ScrollableArea::GetFrameViewBase and move ScheduleAnimation into subclasses. (Closed)

Patch Set: Remove UNREACHED Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/LocalFrame.cpp ('K') | « third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.h ('k') | third_party/WebKit/Source/platform/HostWindow.h » ('j') | third_party/WebKit/Source/platform/HostWindow.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp

diff --git a/third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp b/third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp

index 19491746627ef61de82f3f3a4ba3f4502febe3f9..62dbd294c4de1b4c8de2c46e468fe6349af999dc 100644

--- a/third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp

+++ b/third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp

@@ -83,7 +83,7 @@ void SVGImageChromeClient::ResumeAnimation() {

ScheduleAnimation(nullptr);

}

-void SVGImageChromeClient::ScheduleAnimation(FrameViewBase*) {

+void SVGImageChromeClient::ScheduleAnimation(LocalFrame*) {

// Because a single SVGImage can be shared by multiple pages, we can't key

// our svg image layout on the page's real animation frame. Therefore, we

// run this fake animation timer to trigger layout in SVGImages. The name,