Remove ScrollableArea::GetFrameViewBase and move ScheduleAnimation into subclasses.

third_party/WebKit/Source/core/frame/LocalFrame.cpp

Index: third_party/WebKit/Source/core/frame/LocalFrame.cpp
diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.cpp b/third_party/WebKit/Source/core/frame/LocalFrame.cpp
index b64d75d627f1238ca45956bd77918f23f4ac64a6..72a39b9a23dbd7ef4d9d780b907697989d3f3764 100644
--- a/third_party/WebKit/Source/core/frame/LocalFrame.cpp
+++ b/third_party/WebKit/Source/core/frame/LocalFrame.cpp
@@ -78,6 +78,7 @@
 #include "core/svg/SVGDocumentExtensions.h"
 #include "core/timing/Performance.h"
 #include "platform/DragImage.h"
+#include "platform/HostWindow.h"
 #include "platform/PluginScriptForbiddenScope.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "platform/ScriptForbiddenScope.h"
@@ -872,6 +873,14 @@ void LocalFrame::RegisterInitializationCallback(FrameInitCallback callback) {
   GetInitializationVector().push_back(callback);
 }
 
+bool LocalFrame::ScheduleAnimation(HostWindow* window) {

[dcheng, 2017/04/19 11:26:25]

Can we avoid plumbing HostWindow* through here?

[joelhockey, 2017/04/19 11:33:17]

Yes, I've fixed this in https://codereview.chromium.org/2829613002

+  if (window) {
+    window->ScheduleAnimation(this);

[slangley, 2017/04/19 07:15:45]

seems weird not to have HostWindow::ScheduleAnimation return a bool as well and
then plumb that result out through here ... but i guess that's the way it's
always been?

[joelhockey, 2017/04/19 07:20:47]

Yes, it's kind of hard to know what the bool even means.  There does appear to
be one place where it is checked.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/scrol...

[haraken, 2017/04/19 09:44:07]

Yeah, would you fix it in a follow-up?

[joelhockey, 2017/04/19 10:27:54]

I've looked a little, but I'm not sure that I can really improve this much. 
I've made a note to look at it more later.

+    return true;
+  }
+  return false;
+}
+
 inline LocalFrame::LocalFrame(LocalFrameClient* client,
                               Page& page,
                               FrameOwner* owner,