third_party/WebKit/Source/core/frame/VisualViewport.h - Issue 2826893003: Remove ScrollableArea::GetFrameViewBase and move ScheduleAnimation into subclasses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/VisualViewport.h

Issue 2826893003: Remove ScrollableArea::GetFrameViewBase and move ScheduleAnimation into subclasses. (Closed)

Patch Set: Remove UNREACHED Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/VisualViewport.h

diff --git a/third_party/WebKit/Source/core/frame/VisualViewport.h b/third_party/WebKit/Source/core/frame/VisualViewport.h

index 83e26b43c6743313017e9b3d249ffc0adee2566e..25531fba7c9db4379cd9baa11799362bae0eb064 100644

--- a/third_party/WebKit/Source/core/frame/VisualViewport.h

+++ b/third_party/WebKit/Source/core/frame/VisualViewport.h

@@ -209,7 +209,7 @@ class CORE_EXPORT VisualViewport final

GraphicsLayer* LayerForScrolling() const override;

GraphicsLayer* LayerForHorizontalScrollbar() const override;

GraphicsLayer* LayerForVerticalScrollbar() const override;

- FrameViewBase* GetFrameViewBase() override;

+ bool ScheduleAnimation() override;

CompositorAnimationHost* GetCompositorAnimationHost() const override;

CompositorAnimationTimeline* GetCompositorAnimationTimeline() const override;

IntRect VisibleContentRect(