Remove ScrollableArea::GetFrameViewBase and move ScheduleAnimation into subclasses.

third_party/WebKit/Source/core/frame/LocalFrame.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Simon Hausmann <hausmann@kde.org>
  *                     2000 Stefan Schimanski <1Stein@gmx.de>
  *                     2001 George Staikos <staikos@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
  * rights reserved.
  * Copyright (C) 2005 Alexey Proskuryakov <ap@nypop.com>
@@ skipping 60 matching lines @@
 #include "core/page/scrolling/ScrollingCoordinator.h"
 #include "core/paint/ObjectPainter.h"
 #include "core/paint/PaintInfo.h"
 #include "core/paint/PaintLayer.h"
 #include "core/paint/PaintLayerPainter.h"
 #include "core/paint/TransformRecorder.h"
 #include "core/probe/CoreProbes.h"
 #include "core/svg/SVGDocumentExtensions.h"
 #include "core/timing/Performance.h"
 #include "platform/DragImage.h"
+#include "platform/HostWindow.h"
 #include "platform/PluginScriptForbiddenScope.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "platform/ScriptForbiddenScope.h"
 #include "platform/WebFrameScheduler.h"
 #include "platform/graphics/GraphicsContext.h"
 #include "platform/graphics/StaticBitmapImage.h"
 #include "platform/graphics/paint/ClipRecorder.h"
 #include "platform/graphics/paint/PaintCanvas.h"
 #include "platform/graphics/paint/PaintController.h"
 #include "platform/graphics/paint/PaintRecordBuilder.h"
@@ skipping 774 matching lines @@
 }
 
 bool LocalFrame::ShouldThrottleRendering() const {
   return View() && View()->ShouldThrottleRendering();
 }
 
 void LocalFrame::RegisterInitializationCallback(FrameInitCallback callback) {
   GetInitializationVector().push_back(callback);
 }
 
+bool LocalFrame::ScheduleAnimation(HostWindow* window) {

[dcheng, 2017/04/19 11:26:25]

Can we avoid plumbing HostWindow* through here?

[joelhockey, 2017/04/19 11:33:17]

Yes, I've fixed this in https://codereview.chromium.org/2829613002

+  if (window) {
+    window->ScheduleAnimation(this);

[slangley, 2017/04/19 07:15:45]

seems weird not to have HostWindow::ScheduleAnimation return a bool as well and
then plumb that result out through here ... but i guess that's the way it's
always been?

[joelhockey, 2017/04/19 07:20:47]

Yes, it's kind of hard to know what the bool even means.  There does appear to
be one place where it is checked.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/scrol...

[haraken, 2017/04/19 09:44:07]

Yeah, would you fix it in a follow-up?

[joelhockey, 2017/04/19 10:27:54]

I've looked a little, but I'm not sure that I can really improve this much. 
I've made a note to look at it more later.

+    return true;
+  }
+  return false;
+}
+
 inline LocalFrame::LocalFrame(LocalFrameClient* client,
                               Page& page,
                               FrameOwner* owner,
                               InterfaceProvider* interface_provider,
                               InterfaceRegistry* interface_registry)
     : Frame(client, page, owner, LocalWindowProxyManager::Create(*this)),
       frame_scheduler_(page.GetChromeClient().CreateFrameScheduler(
           client->GetFrameBlameContext())),
       loader_(this),
       navigation_scheduler_(NavigationScheduler::Create(this)),
@@ skipping 61 matching lines @@
   if (frame_ && frame_->Client() && frame_->Client()->GetFrameBlameContext())
     frame_->Client()->GetFrameBlameContext()->Enter();
 }
 
 ScopedFrameBlamer::~ScopedFrameBlamer() {
   if (frame_ && frame_->Client() && frame_->Client()->GetFrameBlameContext())
     frame_->Client()->GetFrameBlameContext()->Leave();
 }
 
 }  // namespace blink