Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2826893002: Disabled testOnPageFinishedCalledOnDomModificationAfterNavigation (Closed)

Created:
3 years, 8 months ago by kozy
Modified:
3 years, 8 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disabled testOnPageFinishedCalledOnDomModificationAfterNavigation This test prevents landing aligning console with spec and new fast console. Flakiness is not reproducible locally. BUG=chromium:712937 TBR=boliu@chromium.org Review-Url: https://codereview.chromium.org/2826893002 Cr-Commit-Position: refs/heads/master@{#465471} Committed: https://chromium.googlesource.com/chromium/src/+/336627d485ab179bf38f9097bb2d3171a347ab16

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/PopupWindowTest.java View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
kozy
I decided to disable it temporary because: - it is not reproducible locally, - I ...
3 years, 8 months ago (2017-04-19 02:02:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826893002/1
3 years, 8 months ago (2017-04-19 02:03:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826893002/20001
3 years, 8 months ago (2017-04-19 02:13:38 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 02:32:59 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/336627d485ab179bf38f9097bb2d...

Powered by Google App Engine
This is Rietveld 408576698