Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(20)

Issue 2826843004: Rewrite base::Bind to base::BindOnce with base_bind_rewriters in //chrome/browser/policy (Closed)

Created:
3 years, 3 months ago by tzik
Modified:
3 years, 3 months ago
Reviewers:
emaxx
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrite base::Bind to base::BindOnce with base_bind_rewriters in //chrome/browser/policy This is a generated CL by a clang refactoring tool at //tools/clang/base_bind_rewriters. The tool rewrites base::Bind to base::BindOnce where the resulting Callback is immediately converted to OnceCallback. E.g.: base::PostTask(FROM_HERE, base::Bind(&Foo)); is rewritten to: base::PostTask(FROM_HERE, base::BindOnce(&Foo)); In terms of the behavior change after the rewrite, the OnceCallback implementation moves out the bound argument to the target function, unlike Callback. BUG=554299 Review-Url: https://codereview.chromium.org/2826843004 Cr-Commit-Position: refs/heads/master@{#467242} Committed: https://chromium.googlesource.com/chromium/src/+/56432d951bee9e8162561899c3ac2f0cd524d528

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -47 lines) Patch
M chrome/browser/policy/cloud/cloud_policy_invalidator.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/policy/cloud/test_request_interceptor.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/policy/cloud/user_policy_signin_service_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 13 chunks +36 lines, -32 lines 0 comments Download
M chrome/browser/policy/policy_network_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
tzik
PTAL
3 years, 3 months ago (2017-04-19 13:45:00 UTC) #6
emaxx
lgtm, thanks!
3 years, 3 months ago (2017-04-26 03:45:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826843004/1
3 years, 3 months ago (2017-04-26 04:40:20 UTC) #11
commit-bot: I haz the power
3 years, 3 months ago (2017-04-26 05:26:03 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/56432d951bee9e8162561899c3ac...

Powered by Google App Engine
This is Rietveld 408576698