Issue 282683002: Pepper: Simplify LaunchSelLdr error reporting.

Issue 282683002: Pepper: Simplify LaunchSelLdr error reporting. (Closed)

Created:
6 years, 7 months ago by teravest

Modified:
6 years, 7 months ago

Reviewers:
bbudge

CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, raymes+watch_chromium.org, teravest+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Pepper: Simplify LaunchSelLdr error reporting. This moves error reporting for LaunchSelLdr out of the trusted plugin, removing the need for a callback in ServiceRuntime to unpack the error string and report it. This is part of a larger effort to move all code out of the trusted plugin. BUG=239656 R=bbudge@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270140

Patch Set 1 #

Total comments: 1

Patch Set 2 : nit: add braces #

Patch Set 3 : rebased #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -58 lines)			Patch
M	components/nacl/renderer/nexe_load_manager.h	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	components/nacl/renderer/ppb_nacl_private_impl.cc	View	1 2	4 chunks	+9 lines, -3 lines	0 comments	Download
M	ppapi/api/private/ppb_nacl_private.idl	View	1 2	2 chunks	+1 line, -1 line	0 comments	Download
M	ppapi/c/private/ppb_nacl_private.h	View	1 2	3 chunks	+2 lines, -2 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/nacl_entry_points.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/plugin_error.h	View		1 chunk	+0 lines, -13 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/sel_ldr_launcher_chrome.h	View		3 chunks	+1 line, -2 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/sel_ldr_launcher_chrome.cc	View		3 chunks	+2 lines, -2 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/service_runtime.h	View	1 2	2 chunks	+0 lines, -3 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/service_runtime.cc	View	1 2	2 chunks	+2 lines, -27 lines	0 comments	Download
M	ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

bbudge

lgtm w/1 style nit https://codereview.chromium.org/282683002/diff/1/components/nacl/renderer/ppb_nacl_private_impl.cc File components/nacl/renderer/ppb_nacl_private_impl.cc (right): https://codereview.chromium.org/282683002/diff/1/components/nacl/renderer/ppb_nacl_private_impl.cc#newcode332 components/nacl/renderer/ppb_nacl_private_impl.cc:332: if (load_manager) brackets?

6 years, 7 months ago (2014-05-12 20:50:14 UTC) #2

teravest

6 years, 7 months ago (2014-05-13 17:47:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r270140 (presubmit successful).

Expand Messages | Collapse Messages