Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: ppapi/native_client/src/trusted/plugin/sel_ldr_launcher_chrome.cc

Issue 282683002: Pepper: Simplify LaunchSelLdr error reporting. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/native_client/src/trusted/plugin/sel_ldr_launcher_chrome.cc
diff --git a/ppapi/native_client/src/trusted/plugin/sel_ldr_launcher_chrome.cc b/ppapi/native_client/src/trusted/plugin/sel_ldr_launcher_chrome.cc
index d27de7e459776fcfb537a4b407fb435dffed3cbd..a5789d610e94c156aef9394dc84dc512218ec5d6 100644
--- a/ppapi/native_client/src/trusted/plugin/sel_ldr_launcher_chrome.cc
+++ b/ppapi/native_client/src/trusted/plugin/sel_ldr_launcher_chrome.cc
@@ -19,6 +19,7 @@ bool SelLdrLauncherChrome::Start(const char* url) {
void SelLdrLauncherChrome::Start(
PP_Instance instance,
+ bool main_service_runtime,
const char* url,
bool uses_irt,
bool uses_ppapi,
@@ -29,13 +30,13 @@ void SelLdrLauncherChrome::Start(
bool enable_crash_throttling,
const PPP_ManifestService* manifest_service_interface,
void* manifest_service_user_data,
- PP_Var* error_message,
pp::CompletionCallback callback) {
if (!launch_nacl_process) {
pp::Module::Get()->core()->CallOnMainThread(0, callback, PP_ERROR_FAILED);
return;
}
launch_nacl_process(instance,
+ PP_FromBool(main_service_runtime),
url,
PP_FromBool(uses_irt),
PP_FromBool(uses_ppapi),
@@ -47,7 +48,6 @@ void SelLdrLauncherChrome::Start(
manifest_service_interface,
manifest_service_user_data,
&channel_,
- error_message,
callback.pp_completion_callback());
}

Powered by Google App Engine
This is Rietveld 408576698