Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 2826823002: Revert of Use flat_set in SurfaceAggregator. (Closed)

Created:
3 years, 8 months ago by ojan
Modified:
3 years, 8 months ago
Reviewers:
danakj, brettw, jbauman
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use flat_set in SurfaceAggregator. (patchset #3 id:40001 of https://codereview.chromium.org/2821353002/ ) Reason for revert: Broke cc_unittests SurfaceAggregatorWithResourcesTest.SecureOutputTexture. https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/59212 https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/62502 Original issue's description: > Use flat_set in SurfaceAggregator. > > The sets and maps are typically small or empty and created once. flat_set and > flat_map will have better performance for these workloads. > > See the bug for histograms of sizes. > > Reland of https://codereview.chromium.org/2823043002 with fix. > > BUG=712295 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > TBR=jbauman@chromium.org > > Review-Url: https://codereview.chromium.org/2821353002 > Cr-Commit-Position: refs/heads/master@{#465324} > Committed: https://chromium.googlesource.com/chromium/src/+/1ac5a973f47b2052df313bab17da120fae22190e TBR=jbauman@chromium.org,danakj@chromium.org,brettw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=712295 Review-Url: https://codereview.chromium.org/2826823002 Cr-Commit-Position: refs/heads/master@{#465413} Committed: https://chromium.googlesource.com/chromium/src/+/1166f4428a18a1cacdeb9e4c310ee7b96cda63b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -32 lines) Patch
M cc/surfaces/surface_aggregator.h View 7 chunks +19 lines, -13 lines 0 comments Download
M cc/surfaces/surface_aggregator.cc View 11 chunks +19 lines, -19 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
ojan
Created Revert of Use flat_set in SurfaceAggregator.
3 years, 8 months ago (2017-04-18 23:01:51 UTC) #2
danakj
It's a really awful bug if things are going thru the CQ and breaking unittests ...
3 years, 8 months ago (2017-04-18 23:02:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826823002/1
3 years, 8 months ago (2017-04-18 23:02:50 UTC) #4
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 23:04:11 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1166f4428a18a1cacdeb9e4c310e...

Powered by Google App Engine
This is Rietveld 408576698