Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2826803004: [ES6 modules] Introduce ModulatorImpl (Closed)

Created:
3 years, 8 months ago by kouhei (in TOK)
Modified:
3 years, 8 months ago
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ES6 modules] Introduce ModulatorImpl This CL introduces ModulatorImpl, which is an implementation of "settings object" spec concept + serves as a backplane for tieing all ES6 module algorithm components together. See below diagram for where it stands in the stack: https://docs.google.com/document/d/1vjiWxwhg9D0GNNOYgw3AxMG0iKOC9I3jlID4GTgZsac/edit#heading=h.47x0qrpzjbj4 BUG=594639 Review-Url: https://codereview.chromium.org/2826803004 Cr-Commit-Position: refs/heads/master@{#465506} Committed: https://chromium.googlesource.com/chromium/src/+/521525f8507b6525eceed9724bd9a5f66f078eda

Patch Set 1 #

Patch Set 2 : classcommt #

Total comments: 4

Patch Set 3 : nhiroki #

Patch Set 4 : no double private #

Unified diffs Side-by-side diffs Delta from patch set Stats (+247 lines, -1 line) Patch
M third_party/WebKit/Source/core/dom/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Modulator.cpp View 2 chunks +15 lines, -1 line 0 comments Download
A third_party/WebKit/Source/core/dom/ModulatorImpl.h View 1 2 3 1 chunk +79 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/ModulatorImpl.cpp View 1 2 1 chunk +151 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
kouhei (in TOK)
3 years, 8 months ago (2017-04-19 01:29:37 UTC) #2
nhiroki
lgtm https://codereview.chromium.org/2826803004/diff/20001/third_party/WebKit/Source/core/dom/ModulatorImpl.cpp File third_party/WebKit/Source/core/dom/ModulatorImpl.cpp (right): https://codereview.chromium.org/2826803004/diff/20001/third_party/WebKit/Source/core/dom/ModulatorImpl.cpp#newcode30 third_party/WebKit/Source/core/dom/ModulatorImpl.cpp:30: ExecutionContext* execution_context, We might not have to pass ...
3 years, 8 months ago (2017-04-19 03:15:47 UTC) #6
kouhei (in TOK)
https://codereview.chromium.org/2826803004/diff/20001/third_party/WebKit/Source/core/dom/ModulatorImpl.cpp File third_party/WebKit/Source/core/dom/ModulatorImpl.cpp (right): https://codereview.chromium.org/2826803004/diff/20001/third_party/WebKit/Source/core/dom/ModulatorImpl.cpp#newcode30 third_party/WebKit/Source/core/dom/ModulatorImpl.cpp:30: ExecutionContext* execution_context, On 2017/04/19 03:15:47, nhiroki wrote: > We ...
3 years, 8 months ago (2017-04-19 03:38:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826803004/60001
3 years, 8 months ago (2017-04-19 03:44:59 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/521525f8507b6525eceed9724bd9a5f66f078eda
3 years, 8 months ago (2017-04-19 05:57:31 UTC) #13
hiroshige
3 years, 8 months ago (2017-04-19 21:26:26 UTC) #14
Message was sent while issue was closed.
On 2017/04/19 05:57:31, commit-bot: I haz the power wrote:
> Committed patchset #4 (id:60001) as
>
https://chromium.googlesource.com/chromium/src/+/521525f8507b6525eceed9724bd9...

lgtm

Powered by Google App Engine
This is Rietveld 408576698