Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2826783003: Rewrite base::Bind to base::BindOnce with base_bind_rewriters in //chrome/browser/browsing_data (Closed)

Created:
3 years, 8 months ago by tzik
Modified:
3 years, 8 months ago
Reviewers:
msramek
CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org, nhiroki, jkarlin+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrite base::Bind to base::BindOnce with base_bind_rewriters in //chrome/browser/browsing_data This is a generated CL by a clang refactoring tool at //tools/clang/base_bind_rewriters. The tool rewrites base::Bind to base::BindOnce where the resulting Callback is immediately converted to OnceCallback. E.g.: base::PostTask(FROM_HERE, base::Bind(&Foo)); is rewritten to: base::PostTask(FROM_HERE, base::BindOnce(&Foo)); In terms of the behavior change after the rewrite, the OnceCallback implementation moves out the bound argument to the target function, unlike Callback. BUG=554299 TBR=msramek@chromium.org Review-Url: https://codereview.chromium.org/2826783003 Cr-Commit-Position: refs/heads/master@{#465594} Committed: https://chromium.googlesource.com/chromium/src/+/ae9f0e30a93e9d3cda9a4254164592363c2c3c44

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -161 lines) Patch
M chrome/browser/browsing_data/autofill_counter_browsertest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_appcache_helper.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_cache_storage_helper.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_channel_id_helper.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_cookie_helper.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_database_helper.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_file_system_helper.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_indexed_db_helper.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_local_storage_helper.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_media_license_helper.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_quota_helper_impl.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover_browsertest.cc View 3 chunks +17 lines, -15 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover_impl.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover_impl_unittest.cc View 3 chunks +11 lines, -12 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_service_worker_helper.cc View 3 chunks +11 lines, -12 lines 0 comments Download
M chrome/browser/browsing_data/cache_counter_browsertest.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc View 8 chunks +24 lines, -26 lines 0 comments Download
M chrome/browser/browsing_data/site_data_counting_helper.cc View 8 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/browsing_data/site_data_counting_helper_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
tzik
msramek: This is the c/b/browsing_data part of http://crrev.com/2825003002. Thanks for reviewing the original CL. Let ...
3 years, 8 months ago (2017-04-19 13:16:33 UTC) #8
msramek
RS LGTM
3 years, 8 months ago (2017-04-19 13:26:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826783003/1
3 years, 8 months ago (2017-04-19 14:17:41 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 14:22:51 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ae9f0e30a93e9d3cda9a42541645...

Powered by Google App Engine
This is Rietveld 408576698