Fix a bug of black area on window close

Fix a bug of black area on window close

Delay 100 ms before closing the window to give some time for
rendering jobs to be done.

BUG=649218
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2826753002
Cr-Commit-Position: refs/heads/master@{#465732}
Committed: https://chromium.googlesource.com/chromium/src/+/476724766017697a95a37e4b29db33005b075dbb

[weidongg, 2017-04-18 18:58:59]

Description was changed from

==========
Fix a bug of black area on window close

Delay 100 ms before closing the window to give some time for
rendering jobs to be done.

BUG=649218
==========

to

==========
Fix a bug of black area on window close

Delay 100 ms before closing the window to give some time for
rendering jobs to be done.

BUG=649218
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[weidongg, 2017-04-18 19:00:46]

weidongg@chromium.org changed reviewers:
+ afakhry@chromium.org

[afakhry, 2017-04-18 19:07:25]

https://codereview.chromium.org/2826753002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/feedback/js/feedback.js (right):

https://codereview.chromium.org/2826753002/diff/20001/chrome/browser/resource...
chrome/browser/resources/feedback/js/feedback.js:204: setTimeout(function() {
window.close();}, 100);
code repetition is not ok. Please create a function, say, scheduleWindowClose()
that you call from all those places.

[weidongg, 2017-04-18 19:28:55]

https://codereview.chromium.org/2826753002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/feedback/js/feedback.js (right):

https://codereview.chromium.org/2826753002/diff/20001/chrome/browser/resource...
chrome/browser/resources/feedback/js/feedback.js:204: setTimeout(function() {
window.close();}, 100);
On 2017/04/18 19:07:25, afakhry wrote:
> code repetition is not ok. Please create a function, say,
scheduleWindowClose()
> that you call from all those places.

Done.

[afakhry, 2017-04-19 17:11:11]

lgtm

[weidongg, 2017-04-19 19:03:46]

The CQ bit was checked by weidongg@chromium.org

[commit-bot: I haz the power, 2017-04-19 19:04:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 20:34:53]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492628626986160,
"parent_rev": "e289daa9258b8646c54ae1dfcbda3f8843ba4012", "commit_rev":
"476724766017697a95a37e4b29db33005b075dbb"}

[commit-bot: I haz the power, 2017-04-19 20:35:01]

Description was changed from

==========
Fix a bug of black area on window close

Delay 100 ms before closing the window to give some time for
rendering jobs to be done.

BUG=649218
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix a bug of black area on window close

Delay 100 ms before closing the window to give some time for
rendering jobs to be done.

BUG=649218
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2826753002
Cr-Commit-Position: refs/heads/master@{#465732}
Committed:
https://chromium.googlesource.com/chromium/src/+/476724766017697a95a37e4b29db...
==========

[commit-bot: I haz the power, 2017-04-19 20:35:02]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/476724766017697a95a37e4b29db...