Add Chrome version check decorators

Add Chrome version check decorators

Uses lazy loading to only get the version when needed, and uses a global
variable (yuck) to store it for all future test runs.

BUG=712688
Review-Url: https://codereview.chromium.org/2826733002
Cr-Commit-Position: refs/heads/master@{#466390}
Committed: https://chromium.googlesource.com/chromium/src/+/9378ff37d394367870aec12cef1c9ee42633fe39

[Robert Ogden, 2017-04-18 18:50:15]

robertogden@chromium.org changed reviewers:
+ ryansturm@chromium.org

[Robert Ogden, 2017-04-18 18:50:16]

Ryan, please take a look. Thanks!

[RyanSturm, 2017-04-18 18:53:13]

ryansturm@chromium.org changed reviewers:
+ bengr@chromium.org

[RyanSturm, 2017-04-18 18:53:14]

Adding bengr. I still think storing a frozen version of the integration test
code once it hits stable is the better option, but I defer to Ben on this one.

[bengr, 2017-04-20 00:46:14]

On 2017/04/18 18:53:14, Ryan Sturm wrote:
> Adding bengr. I still think storing a frozen version of the integration test
> code once it hits stable is the better option, but I defer to Ben on this one.

Yeah, I agree with Ryan. The caveat is that decorators would be a lot easier for
two cases:
1) testing archived releases, because you wouldn't have to fetch old source as
well.
2) documenting the evolution of expected behavior in one location.

Robert, I'm fine either way. Discuss with Richard. If you can come to a workable
solution for (1) without this CL, then I'd forego the CL.

[bustamante, 2017-04-20 18:22:35]

On 2017/04/20 00:46:14, bengr wrote:
> On 2017/04/18 18:53:14, Ryan Sturm wrote:
> > Adding bengr. I still think storing a frozen version of the integration test
> > code once it hits stable is the better option, but I defer to Ben on this
one.
> 
> Yeah, I agree with Ryan. The caveat is that decorators would be a lot easier
for
> two cases:
> 1) testing archived releases, because you wouldn't have to fetch old source as
> well.
> 2) documenting the evolution of expected behavior in one location.
> 
> Robert, I'm fine either way. Discuss with Richard. If you can come to a
workable
> solution for (1) without this CL, then I'd forego the CL.

I'd rather go with the decorator option.  There are several scenarios where we
want changes to propagate back, like a server change that requires updates to
the tests, new tests that are backwards compatible, and changes to the test
infrastructure (like a new device / platform).

It would be easier to have ToT be the source of truth for all that, than trying
to maintain k branches of stable.

[RyanSturm, 2017-04-20 21:53:38]

lgtm if this is the best way to do it WRT infrastructure.

[Robert Ogden, 2017-04-20 22:37:57]

The CQ bit was checked by robertogden@chromium.org

[commit-bot: I haz the power, 2017-04-20 22:38:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 22:41:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 22:41:23]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Robert Ogden, 2017-04-21 03:54:53]

The CQ bit was checked by robertogden@chromium.org

[commit-bot: I haz the power, 2017-04-21 03:55:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 04:03:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 04:03:16]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Robert Ogden, 2017-04-21 17:58:54]

The CQ bit was checked by robertogden@chromium.org

[commit-bot: I haz the power, 2017-04-21 17:59:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 18:07:56]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492797534247230, "parent_rev":
"9264f7911c85f9bcb3c357b7f2989a70a0c3aef8", "commit_rev":
"9378ff37d394367870aec12cef1c9ee42633fe39"}

[commit-bot: I haz the power, 2017-04-21 18:08:08]

Description was changed from

==========
Add Chrome version check decorators

Uses lazy loading to only get the version when needed, and uses a global
variable (yuck) to store it for all future test runs.

BUG=712688
==========

to

==========
Add Chrome version check decorators

Uses lazy loading to only get the version when needed, and uses a global
variable (yuck) to store it for all future test runs.

BUG=712688

Review-Url: https://codereview.chromium.org/2826733002
Cr-Commit-Position: refs/heads/master@{#466390}
Committed:
https://chromium.googlesource.com/chromium/src/+/9378ff37d394367870aec12cef1c...
==========

[commit-bot: I haz the power, 2017-04-21 18:08:09]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9378ff37d394367870aec12cef1c...

[bengr, 2017-05-05 17:53:29]

Hmm, fwiw, I never published these nits.

https://codereview.chromium.org/2826733002/diff/1/tools/chrome_proxy/webdrive...
File tools/chrome_proxy/webdriver/decorator_smoke.py (right):

https://codereview.chromium.org/2826733002/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/decorator_smoke.py:24: @ChromeVersionBeforeM(0)
Hmm. Maybe call this ChromeMaximumMilestone or ChromeMaxMilestone?

https://codereview.chromium.org/2826733002/diff/1/tools/chrome_proxy/webdrive...
File tools/chrome_proxy/webdriver/decorators.py (right):

https://codereview.chromium.org/2826733002/diff/1/tools/chrome_proxy/webdrive...
tools/chrome_proxy/webdriver/decorators.py:83:
t.LoadURL('http://check.googlezip.net/connect')
Maybe use a standard gen_204 page, or just scrape chrome://version?