Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2826713004: Fix wrong inclusion of .cc file in ash/ (Closed)

Created:
3 years, 8 months ago by emaxx
Modified:
3 years, 8 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix wrong inclusion of .cc file in ash/ BUG=713138 Review-Url: https://codereview.chromium.org/2826713004 Cr-Commit-Position: refs/heads/master@{#465636} Committed: https://chromium.googlesource.com/chromium/src/+/2eba57eb76c34bb5d8f8fe844c8b535776694916

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ash/accelerators/accelerator_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/accelerator_interactive_uitest_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
emaxx
jamescook@: PTAL.
3 years, 8 months ago (2017-04-19 12:19:04 UTC) #6
James Cook
lgtm
3 years, 8 months ago (2017-04-19 16:29:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826713004/1
3 years, 8 months ago (2017-04-19 16:43:31 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 16:47:41 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2eba57eb76c34bb5d8f8fe844c8b...

Powered by Google App Engine
This is Rietveld 408576698