Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1359)

Issue 2826713003: Disable tests on VS 2017 RTM, code-gen bug (Closed)

Created:
3 years, 8 months ago by brucedawson
Modified:
3 years, 8 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable tests on VS 2017 RTM, code-gen bug VS 2017 RTM has what appears to be a code-gen bug. This bug is discussed and reported here: https://developercommunity.visualstudio.com/content/problem/40904/bad-code-gen-in-chromes-mojo-public-bindings-unitt.html In order to allow us to make forward progress, such as trying a canary build of Chrome with VS 2017, this CL disables the four affected tests for the VS 2017 RTM compiler only. BUG=683729 Review-Url: https://codereview.chromium.org/2826713003 Cr-Commit-Position: refs/heads/master@{#465420} Committed: https://chromium.googlesource.com/chromium/src/+/9191144caf319a8992012d8b5260b0c65cd987ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M mojo/public/cpp/bindings/tests/pickle_unittest.cc View 4 chunks +19 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
brucedawson
Uggh. I hate this, but I *think* it's the right thing to do. PTAL.
3 years, 8 months ago (2017-04-18 21:46:45 UTC) #7
jam
lgtm
3 years, 8 months ago (2017-04-18 21:51:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826713003/1
3 years, 8 months ago (2017-04-18 23:13:52 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 23:22:21 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9191144caf319a8992012d8b5260...

Powered by Google App Engine
This is Rietveld 408576698