Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2826693005: Rename |selection_controller_| to |touch_selection_controller_| (Closed)

Created:
3 years, 8 months ago by Jinsuk Kim
Modified:
3 years, 8 months ago
Reviewers:
boliu
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename |selection_controller_| to |touch_selection_controller_| This is a prework for upcoming SelectionPopupController in RenderWidgetHostViewAndroid, to avoid confusion on names of the variables. BUG=662908 Review-Url: https://codereview.chromium.org/2826693005 Cr-Commit-Position: refs/heads/master@{#465503} Committed: https://chromium.googlesource.com/chromium/src/+/64dafab9bb2755e8866dc4efa778302598dfd6ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -24 lines) Patch
M content/browser/renderer_host/render_widget_host_view_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 11 chunks +24 lines, -23 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Jinsuk Kim
Note: I suppose you wanted this change to be on its own CL. From https://crrev.com/2792063003 ...
3 years, 8 months ago (2017-04-19 02:10:01 UTC) #2
boliu
lgtm
3 years, 8 months ago (2017-04-19 04:53:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826693005/1
3 years, 8 months ago (2017-04-19 05:18:56 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 05:48:33 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/64dafab9bb2755e8866dc4efa778...

Powered by Google App Engine
This is Rietveld 408576698