Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2826693002: Fix create_include_gyp.py to support relative paths to include_js.gypi (Closed)

Created:
3 years, 8 months ago by Dan Beam
Modified:
3 years, 8 months ago
Reviewers:
oka
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, fukino+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org, fukino
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix create_include_gyp.py to support relative paths to include_js.gypi This is to allow ui/file_manager/externs/compiled_resources2.gyp to be generated. This seems like a good idea, as there were a few targets that no longer actually exist in this file. R=oka@chromium.org BUG=636289 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2826693002 Cr-Commit-Position: refs/heads/master@{#465310} Committed: https://chromium.googlesource.com/chromium/src/+/08e2c2a4a4630b46712e0cd1900e15980c8fe203

Patch Set 1 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M third_party/closure_compiler/externs/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/closure_compiler/interfaces/compiled_resources2.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/closure_compiler/tools/create_include_gyp.py View 2 chunks +8 lines, -5 lines 0 comments Download
M ui/file_manager/externs/compiled_resources2.gyp View 4 chunks +7 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Dan Beam
3 years, 8 months ago (2017-04-18 18:10:36 UTC) #5
oka
lgtm Thank you!
3 years, 8 months ago (2017-04-18 18:42:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826693002/20001
3 years, 8 months ago (2017-04-18 18:49:42 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 18:57:03 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/08e2c2a4a4630b46712e0cd1900e...

Powered by Google App Engine
This is Rietveld 408576698