Fix a crash bug on deallocating CWVWebView.

Fix a crash bug on deallocating CWVWebView.

The cause of the bug was that CWVWebView._configuration was deallocated
before CWVWebView._webState, while the order must be opposite.

I couldn't find a clear documentation of the order of deallocation of
fields, but looks like it's the reverse order of the field definitions
(the same as in C++), while it assumes implicitly defined fields (by
@synthesize) are defined after explicitly defined fields.

The fix here is to define both fields explicitly in |_configuration| ->
|_webState| order so that they are deallocated in |_webState| ->
|_configuration| order.

BUG=712556
Review-Url: https://codereview.chromium.org/2826663002
Cr-Commit-Position: refs/heads/master@{#465465}
Committed: https://chromium.googlesource.com/chromium/src/+/068120a076d669c081f8c77cc0eccacaac650cb5

[Hiroshi Ichikawa, 2017-04-18 07:45:20]

Description was changed from

==========
Fix a crash bug on deallocating CWVWebView.

BUG=712556
==========

to

==========
Fix a crash bug on deallocating CWVWebView.

The cause of the bug was that CWVWebView._configuration was deallocated
before CWVWebView._webState, while the order must be opposite.

I couldn't find a clear documentation of the order of deallocation of
fields, but looks like it's the reverse order of the field definitions
(the same as in C++), while it assumes implicitly defined fields (by
@synthesize) are defined after explicitly defined fields.

The fix here is to define both fields explicitly in |_configuration| ->
|_webState| order so that they are deallocated in |_webState| ->
|_configuration| order.

BUG=712556
==========

[Hiroshi Ichikawa, 2017-04-18 08:00:38]

ichikawa@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-04-18 15:22:42]

lgtm

[Hiroshi Ichikawa, 2017-04-19 01:46:27]

The CQ bit was checked by ichikawa@chromium.org

[commit-bot: I haz the power, 2017-04-19 01:46:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 01:58:22]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492566387296360, "parent_rev":
"266addfa343d611326cd8a6e7ecb4f7b65dde2d9", "commit_rev":
"068120a076d669c081f8c77cc0eccacaac650cb5"}

[commit-bot: I haz the power, 2017-04-19 01:58:31]

Description was changed from

==========
Fix a crash bug on deallocating CWVWebView.

The cause of the bug was that CWVWebView._configuration was deallocated
before CWVWebView._webState, while the order must be opposite.

I couldn't find a clear documentation of the order of deallocation of
fields, but looks like it's the reverse order of the field definitions
(the same as in C++), while it assumes implicitly defined fields (by
@synthesize) are defined after explicitly defined fields.

The fix here is to define both fields explicitly in |_configuration| ->
|_webState| order so that they are deallocated in |_webState| ->
|_configuration| order.

BUG=712556
==========

to

==========
Fix a crash bug on deallocating CWVWebView.

The cause of the bug was that CWVWebView._configuration was deallocated
before CWVWebView._webState, while the order must be opposite.

I couldn't find a clear documentation of the order of deallocation of
fields, but looks like it's the reverse order of the field definitions
(the same as in C++), while it assumes implicitly defined fields (by
@synthesize) are defined after explicitly defined fields.

The fix here is to define both fields explicitly in |_configuration| ->
|_webState| order so that they are deallocated in |_webState| ->
|_configuration| order.

BUG=712556

Review-Url: https://codereview.chromium.org/2826663002
Cr-Commit-Position: refs/heads/master@{#465465}
Committed:
https://chromium.googlesource.com/chromium/src/+/068120a076d669c081f8c77cc0ec...
==========

[commit-bot: I haz the power, 2017-04-19 01:58:31]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/068120a076d669c081f8c77cc0ec...