third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl - Issue 2826653002: Generate getters/setters for some fields on groups in ComputedStyle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl

Issue 2826653002: Generate getters/setters for some fields on groups in ComputedStyle (Closed)

Patch Set: Add new macro argument_type to be used in setter macros Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl ('K') | « third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl ('k') | third_party/WebKit/Source/build/scripts/templates/fields/keyword.tmpl » ('j') | third_party/WebKit/Source/build/scripts/templates/fields/storage_only.tmpl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl b/third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl

index 8790c220a74458dfa70c7a5238d35b8e99f6a1ab..fd366ae6979722c3d32902d1e202fe74d33ad559 100644

--- a/third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl

@@ -18,6 +18,14 @@ static_cast<{{field.type_name}}>({{value}})

{% if field.is_bit_field -%}

{%- else -%}

-const {{field.type_name}}&

+{{field.type_name}}&

{%- endif %}

{% endmacro %}

+{% macro argument_type(field) %}

+{% if field.is_bit_field -%}

+{{field.type_name}}

+{%- else -%}

+{{field.type_name}}&

suzyh_UTC10 (ex-contributor) 2017/04/20 00:12:18 Did you mean a const & here?

nainar 2017/04/20 02:53:04 Done.

+{%- endif %}

+{% endmacro %}