Chromium Code Reviews Chromium Code Reviews
Issue 2826653002:
Generate getters/setters for some fields on groups in ComputedStyle (Closed)
| OLD | NEW |
|---|---|
| 1 {% macro encode(field, value) %} | 1 {% macro encode(field, value) %} |
| 2 {% if field.is_bit_field -%} | 2 {% if field.is_bit_field -%} |
| 3 static_cast<unsigned>({{value}}) | 3 static_cast<unsigned>({{value}}) |
| 4 {%- else -%} | 4 {%- else -%} |
| 5 {{value}} | 5 {{value}} |
| 6 {%- endif %} | 6 {%- endif %} |
| 7 {% endmacro %} | 7 {% endmacro %} |
| 8 | 8 |
| 9 {% macro decode(field, value) %} | 9 {% macro decode(field, value) %} |
| 10 {% if field.is_bit_field -%} | 10 {% if field.is_bit_field -%} |
| 11 static_cast<{{field.type_name}}>({{value}}) | 11 static_cast<{{field.type_name}}>({{value}}) |
| 12 {%- else -%} | 12 {%- else -%} |
| 13 {{value}} | 13 {{value}} |
| 14 {%- endif %} | 14 {%- endif %} |
| 15 {% endmacro %} | 15 {% endmacro %} |
| 16 | 16 |
| 17 {% macro return_type(field) %} | 17 {% macro return_type(field) %} |
| 18 {% if field.is_bit_field -%} | 18 {% if field.is_bit_field -%} |
| 19 {{field.type_name}} | 19 {{field.type_name}} |
| 20 {%- else -%} | 20 {%- else -%} |
| 21 const {{field.type_name}}& | 21 {{field.type_name}}& |
| 22 {%- endif %} | 22 {%- endif %} |
| 23 {% endmacro %} | 23 {% endmacro %} |
| 24 | |
| 25 {% macro argument_type(field) %} | |
| 26 {% if field.is_bit_field -%} | |
| 27 {{field.type_name}} | |
| 28 {%- else -%} | |
| 29 {{field.type_name}}& | |
|
suzyh_UTC10 (ex-contributor)
2017/04/20 00:12:18
Did you mean a const & here?
nainar
2017/04/20 02:53:04
Done.
| |
| 30 {%- endif %} | |
| 31 {% endmacro %} | |
| OLD | NEW |
