Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

Issue 2826653002: Generate getters/setters for some fields on groups in ComputedStyle (Closed)
Patch Set: Incorporating shend@'s suggestions Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl
diff --git a/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl b/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl
index 03a48012e77dde6c9d76d4582bd0b1692826e4ba..bbd444f08313a406cf7f2d8d000f3c8884636d13 100644
--- a/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl
+++ b/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl
@@ -81,7 +81,7 @@ class CORE_EXPORT ComputedStyleBase {
{% for field in fields %}
// {{field.property_name}}
- {{field_templates[field.field_template].decl_methods(field)|indent(2)}}
+ {{field_templates[field.field_template].decl_public_methods(field)|indent(2)}}
{% endfor %}
protected:
@@ -93,6 +93,14 @@ class CORE_EXPORT ComputedStyleBase {
{% endfor %}
{}
+ {% for field in fields %}
+ {% if field.field_template in ('storage_only', 'monotonic_flag', 'external') %}
suzyh_UTC10 (ex-contributor) 2017/04/19 08:03:33 Why 'external'? This is not mentioned in the CL de
nainar 2017/04/19 08:49:35 Forgot to update the CL - done now.
suzyh_UTC10 (ex-contributor) 2017/04/20 00:12:18 The headline of the CL description does not mentio
suzyh_UTC10 (ex-contributor) 2017/04/20 03:48:02 Missed this comment?
nainar 2017/04/20 05:15:58 Edited it to some fields. And yes I did miss it.
+ // {{field.property_name}}
+ {{field_templates[field.field_template].decl_protected_methods(field)|indent(2)}}
+
+ {% endif %}
+ {% endfor %}
+
~ComputedStyleBase() = default;
// Storage.

Powered by Google App Engine
This is Rietveld 408576698