Generate getters/setters for some fields on groups in ComputedStyle

third_party/WebKit/Source/build/scripts/make_computed_style_base.py

Index: third_party/WebKit/Source/build/scripts/make_computed_style_base.py
diff --git a/third_party/WebKit/Source/build/scripts/make_computed_style_base.py b/third_party/WebKit/Source/build/scripts/make_computed_style_base.py
index fbb0aff6366e0d9a2d3d65e2eb8eb658f45d8fde..982f62f0cf6e5a59b2cc15a39e55a2e82ae6b001 100755
--- a/third_party/WebKit/Source/build/scripts/make_computed_style_base.py
+++ b/third_party/WebKit/Source/build/scripts/make_computed_style_base.py
@@ -134,6 +134,9 @@ class Field(object):
         # Method names
         self.getter_method_name = getter_method_name
         self.setter_method_name = setter_method_name
+        self.internal_getter_method_name = method_name(join_name(getter_method_name, 'Internal'))
+        self.internal_mutable_method_name = method_name(join_name('Mutable', name_for_methods, 'Internal'))

[suzyh_UTC10 (ex-contributor), 2017/04/19 08:03:33]

The class doc says name_for_methods is the name used to form getter_method_name
and setter_method_name. Why are {getter,setter}_method_name passed in as
arguments, in that case?

[nainar, 2017/04/19 08:49:35]

That's because we need them as input to form the name for the protected
getters/setters. They need to have the word Internal appended to them

[suzyh_UTC10 (ex-contributor), 2017/04/20 00:12:18]

Clarification: I meant why not construct {getter,setter}_method_name here in
this function from name_for_methods?

[nainar, 2017/04/20 02:53:04]

So turns out I was stupid in explaining it to you twice. We are passing in
{getter/setter}_method_name as they can be overriden. See here() for an example.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/CSSPr...

[suzyh_UTC10 (ex-contributor), 2017/04/20 03:48:02]

Aha! OK then. Ideally we'd tidy this up, so optionally consider filing a
bug/adding a TODO.

[nainar, 2017/04/20 05:15:58]

Done.

+        self.internal_setter_method_name = method_name(join_name(setter_method_name, 'Internal'))
         self.initial_method_name = initial_method_name
         self.resetter_method_name = method_name(join_name('Reset', name_for_methods))