Convert Incognito New Tab Page from i18n-* (JS) to $i18n{} (C++)

Convert Incognito New Tab Page from i18n-* (JS) to $i18n{} (C++)

R=dschuyler@chromium.org
BUG=677338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2826643002
Cr-Commit-Position: refs/heads/master@{#465843}
Committed: https://chromium.googlesource.com/chromium/src/+/1f5b91b54c1650e14277f39dc1baa1ff096c75b6

[Dan Beam, 2017-04-18 05:14:48]

Description was changed from

==========
Convert Incognito New Tab Page from i18n-* (JS) to $i18n{} (C++)

R=dschuyler@chromium.org
BUG=677338
==========

to

==========
Convert Incognito New Tab Page from i18n-* (JS) to $i18n{} (C++)

R=dschuyler@chromium.org
BUG=677338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-04-18 05:18:22]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 05:18:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 06:20:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 06:20:54]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2017-04-19 01:37:31]

lgtm

https://codereview.chromium.org/2826643002/diff/1/chrome/browser/ui/webui/ntp...
File chrome/browser/ui/webui/ntp/ntp_resource_cache.cc (right):

https://codereview.chromium.org/2826643002/diff/1/chrome/browser/ui/webui/ntp...
chrome/browser/ui/webui/ntp/ntp_resource_cache.cc:279: : "false";
Can this get a comment noting that this is a workaround; or that the CSS is
specifically looking for bookmarkbarattached=true. I'm concerned this will
become the-way (example) of how to use a boolean.

Or maybe a TODO(dschuyler): consider supporting booleans in i18n.

[Dan Beam, 2017-04-20 00:10:53]

https://codereview.chromium.org/2826643002/diff/1/chrome/browser/ui/webui/ntp...
File chrome/browser/ui/webui/ntp/ntp_resource_cache.cc (right):

https://codereview.chromium.org/2826643002/diff/1/chrome/browser/ui/webui/ntp...
chrome/browser/ui/webui/ntp/ntp_resource_cache.cc:279: : "false";
On 2017/04/19 01:37:30, dschuyler wrote:
> Can this get a comment noting that this is a workaround; or that the CSS is
> specifically looking for bookmarkbarattached=true. I'm concerned this will
> become the-way (example) of how to use a boolean.
> 
> Or maybe a TODO(dschuyler): consider supporting booleans in i18n.

Done.

[Dan Beam, 2017-04-20 00:11:02]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2017-04-20 00:11:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/2826643002/#ps20001
(title: "todo")

[commit-bot: I haz the power, 2017-04-20 00:11:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 01:11:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492647062575790,
"parent_rev": "a7c22ed31c0df9c516c343782a2f02389b965c55", "commit_rev":
"1f5b91b54c1650e14277f39dc1baa1ff096c75b6"}

[commit-bot: I haz the power, 2017-04-20 01:12:05]

Description was changed from

==========
Convert Incognito New Tab Page from i18n-* (JS) to $i18n{} (C++)

R=dschuyler@chromium.org
BUG=677338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Convert Incognito New Tab Page from i18n-* (JS) to $i18n{} (C++)

R=dschuyler@chromium.org
BUG=677338
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2826643002
Cr-Commit-Position: refs/heads/master@{#465843}
Committed:
https://chromium.googlesource.com/chromium/src/+/1f5b91b54c1650e14277f39dc1ba...
==========

[commit-bot: I haz the power, 2017-04-20 01:12:07]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1f5b91b54c1650e14277f39dc1ba...