Set Flush/StartPlaying default behavior in RendererImpl unit test

Set Flush/StartPlaying default behavior in RendererImpl unit test

Move the definitions of the default Flush and StartPlaying* behaviors
for audio/video renderers to a common InitializeAndExpect function,
instead of repeatedly definining those behaviors in individual tests.

Review-Url: https://codereview.chromium.org/2826613002
Cr-Commit-Position: refs/heads/master@{#465651}
Committed: https://chromium.googlesource.com/chromium/src/+/cfacebc3d54e22da4e41e763dfb3c6c7525f3e92

[servolk, 2017-04-18 00:42:13]

The CQ bit was checked by servolk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 00:42:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[servolk, 2017-04-18 00:44:18]

Description was changed from

==========
Refactor RendererImpl unit test

Move the definitions of the default Flush and StartPlaying* behaviors
for audio/video renderers to a common InitializeAndExpect function,
instead of repeatedly definining those behaviors in individual tests.
==========

to

==========
Refactor RendererImpl unit test

Move the definitions of the default Flush and StartPlaying* behaviors
for audio/video renderers to a common InitializeAndExpect function,
instead of repeatedly definining those behaviors in individual tests.
==========

[servolk, 2017-04-18 00:44:18]

servolk@chromium.org changed reviewers:
+ xhwang@chromium.org

[commit-bot: I haz the power, 2017-04-18 02:18:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 02:18:10]

Dry run: This issue passed the CQ dry run.

[xhwang, 2017-04-19 06:25:34]

lgtm

The CL title "Refactor RendererImpl unit test" seems too generic. Does it make
sense to say something like "Set Flush() and StartPlayingFrom() default behavior
in RendererImplTest"?

[servolk, 2017-04-19 16:05:50]

Description was changed from

==========
Refactor RendererImpl unit test

Move the definitions of the default Flush and StartPlaying* behaviors
for audio/video renderers to a common InitializeAndExpect function,
instead of repeatedly definining those behaviors in individual tests.
==========

to

==========
Set Flush/StartPlaying default behavior in RendererImpl unit test

Move the definitions of the default Flush and StartPlaying* behaviors
for audio/video renderers to a common InitializeAndExpect function,
instead of repeatedly definining those behaviors in individual tests.
==========

[servolk, 2017-04-19 16:06:04]

On 2017/04/19 06:25:34, xhwang_slow wrote:
> lgtm
> 
> The CL title "Refactor RendererImpl unit test" seems too generic. Does it make
> sense to say something like "Set Flush() and StartPlayingFrom() default
behavior
> in RendererImplTest"?

Done

[servolk, 2017-04-19 16:06:08]

The CQ bit was checked by servolk@chromium.org

[commit-bot: I haz the power, 2017-04-19 16:06:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 17:22:41]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492617968911140, "parent_rev":
"39358c18ce1cc85f8d11144800c88c4146cc6b14", "commit_rev":
"cfacebc3d54e22da4e41e763dfb3c6c7525f3e92"}

[commit-bot: I haz the power, 2017-04-19 17:22:56]

Description was changed from

==========
Set Flush/StartPlaying default behavior in RendererImpl unit test

Move the definitions of the default Flush and StartPlaying* behaviors
for audio/video renderers to a common InitializeAndExpect function,
instead of repeatedly definining those behaviors in individual tests.
==========

to

==========
Set Flush/StartPlaying default behavior in RendererImpl unit test

Move the definitions of the default Flush and StartPlaying* behaviors
for audio/video renderers to a common InitializeAndExpect function,
instead of repeatedly definining those behaviors in individual tests.

Review-Url: https://codereview.chromium.org/2826613002
Cr-Commit-Position: refs/heads/master@{#465651}
Committed:
https://chromium.googlesource.com/chromium/src/+/cfacebc3d54e22da4e41e763dfb3...
==========

[commit-bot: I haz the power, 2017-04-19 17:22:59]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cfacebc3d54e22da4e41e763dfb3...