[Payment Request] Sever card summary section in the credit card edit form

[Payment Request] Sever card summary section in the credit card edit form

Displays a PaymentMethodItem in the credit card form in order to identify
the server card being edited.

http://imgur.com/a/CM38f

BUG=602666
Review-Url: https://codereview.chromium.org/2826593005
Cr-Commit-Position: refs/heads/master@{#465706}
Committed: https://chromium.googlesource.com/chromium/src/+/6fa7b73ae0d094df830c607dd59fd6593d086176

[Moe, 2017-04-18 16:07:44]

Description was changed from

==========
[Payment Request] Sever card summary section in the credit card edit form

Displays a PaymentMethodItem in the credit card form in order to identify
the server card being edited.

BUG=602666
==========

to

==========
[Payment Request] Sever card summary section in the credit card edit form

Displays a PaymentMethodItem in the credit card form in order to identify
the server card being edited.

http://imgur.com/a/CM38f

BUG=602666
==========

[Moe, 2017-04-18 16:07:44]

mahmadi@chromium.org changed reviewers:
+ macourteau@chromium.org

[Moe, 2017-04-18 16:08:00]

Hi MAC, Please take a look.

[macourteau, 2017-04-19 15:12:43]

lgtm w/ nits

https://codereview.chromium.org/2826593005/diff/20001/ios/chrome/browser/paym...
File ios/chrome/browser/payments/credit_card_edit_mediator.mm (right):

https://codereview.chromium.org/2826593005/diff/20001/ios/chrome/browser/paym...
ios/chrome/browser/payments/credit_card_edit_mediator.mm:77: int cardTypeIconID
=
nit (personal preference): const

https://codereview.chromium.org/2826593005/diff/20001/ios/chrome/browser/paym...
File ios/chrome/browser/payments/credit_card_edit_view_controller_unittest.mm
(right):

https://codereview.chromium.org/2826593005/diff/20001/ios/chrome/browser/paym...
ios/chrome/browser/payments/credit_card_edit_view_controller_unittest.mm:87:
TestCreditCardEditViewControllerMediator* mediator_;
nit: = nullptr

[Moe, 2017-04-19 19:10:29]

Thank you.

https://codereview.chromium.org/2826593005/diff/20001/ios/chrome/browser/paym...
File ios/chrome/browser/payments/credit_card_edit_mediator.mm (right):

https://codereview.chromium.org/2826593005/diff/20001/ios/chrome/browser/paym...
ios/chrome/browser/payments/credit_card_edit_mediator.mm:77: int cardTypeIconID
=
On 2017/04/19 15:12:42, macourteau wrote:
> nit (personal preference): const

Done.

https://codereview.chromium.org/2826593005/diff/20001/ios/chrome/browser/paym...
File ios/chrome/browser/payments/credit_card_edit_view_controller_unittest.mm
(right):

https://codereview.chromium.org/2826593005/diff/20001/ios/chrome/browser/paym...
ios/chrome/browser/payments/credit_card_edit_view_controller_unittest.mm:87:
TestCreditCardEditViewControllerMediator* mediator_;
On 2017/04/19 15:12:42, macourteau wrote:
> nit: = nullptr

Done.

[Moe, 2017-04-19 19:10:32]

The CQ bit was checked by mahmadi@chromium.org

[Moe, 2017-04-19 19:10:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
macourteau@chromium.org
Link to the patchset: https://codereview.chromium.org/2826593005/#ps40001
(title: "Addressed comments")

[commit-bot: I haz the power, 2017-04-19 19:11:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 19:27:17]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492629032406410,
"parent_rev": "4b18d5f5e02254c2f2088570e66c74db7eeb8e38", "commit_rev":
"6fa7b73ae0d094df830c607dd59fd6593d086176"}

[commit-bot: I haz the power, 2017-04-19 19:27:26]

Description was changed from

==========
[Payment Request] Sever card summary section in the credit card edit form

Displays a PaymentMethodItem in the credit card form in order to identify
the server card being edited.

http://imgur.com/a/CM38f

BUG=602666
==========

to

==========
[Payment Request] Sever card summary section in the credit card edit form

Displays a PaymentMethodItem in the credit card form in order to identify
the server card being edited.

http://imgur.com/a/CM38f

BUG=602666

Review-Url: https://codereview.chromium.org/2826593005
Cr-Commit-Position: refs/heads/master@{#465706}
Committed:
https://chromium.googlesource.com/chromium/src/+/6fa7b73ae0d094df830c607dd59f...
==========

[commit-bot: I haz the power, 2017-04-19 19:27:27]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6fa7b73ae0d094df830c607dd59f...