Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 2826593004: [heap] Reland: Take page lock when scavenging old to new references in Scavenger. (Closed)

Created:
3 years, 8 months ago by Hannes Payer (out of office)
Modified:
3 years, 8 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Reland: Take page lock when scavenging old to new references in Scavenger. BUG=v8:5807 Review-Url: https://codereview.chromium.org/2826593004 Cr-Commit-Position: refs/heads/master@{#44697} Committed: https://chromium.googlesource.com/v8/v8/+/26bc5906295100300252463e2f5914279e30970f

Patch Set 1 #

Patch Set 2 : Use recursive mutex. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -21 lines) Patch
M src/heap/array-buffer-tracker.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/heap/array-buffer-tracker-inl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download
M src/heap/remembered-set.h View 3 chunks +14 lines, -5 lines 0 comments Download
M src/heap/spaces.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/heap/spaces.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (8 generated)
Michael Lippautz
lgtm
3 years, 8 months ago (2017-04-18 16:12:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826593004/20001
3 years, 8 months ago (2017-04-18 17:30:41 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 17:32:25 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/26bc5906295100300252463e2f5914279e3...

Powered by Google App Engine
This is Rietveld 408576698