Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2826593002: Remove ash's MaterialDesignController. (Closed)

Created:
3 years, 8 months ago by Evan Stade
Modified:
3 years, 8 months ago
Reviewers:
James Cook, pkotwicz
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ash's MaterialDesignController. Remove pre-MD code at the last couple of callsites. BUG=686245 TBR=pkotwicz@chromium.org Review-Url: https://codereview.chromium.org/2826593002 Cr-Commit-Position: refs/heads/master@{#465233} Committed: https://chromium.googlesource.com/chromium/src/+/beba3d3c3694aef72793429f3f66ab236c541def

Patch Set 1 #

Patch Set 2 : headers #

Patch Set 3 : one more dead include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -90 lines) Patch
M ash/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D ash/material_design/material_design_controller.h View 1 chunk +0 lines, -32 lines 0 comments Download
D ash/material_design/material_design_controller.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M ash/system/palette/palette_tray.cc View 3 chunks +7 lines, -29 lines 0 comments Download
M ash/system/status_area_widget.cc View 1 2 chunks +1 line, -4 lines 0 comments Download
M ash/wm/overview/window_selector_item.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 21 (14 generated)
Evan Stade
3 years, 8 months ago (2017-04-17 22:35:53 UTC) #3
James Cook
LGTM. Woo hoo!
3 years, 8 months ago (2017-04-18 00:06:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826593002/40001
3 years, 8 months ago (2017-04-18 00:13:44 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/413244)
3 years, 8 months ago (2017-04-18 00:21:06 UTC) #13
Evan Stade
TBR pkotwicz@chromium.org for immersive mode controller
3 years, 8 months ago (2017-04-18 14:38:20 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2826593002/40001
3 years, 8 months ago (2017-04-18 14:38:44 UTC) #18
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 14:43:15 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/beba3d3c3694aef72793429f3f66...

Powered by Google App Engine
This is Rietveld 408576698