Use flat_set for ResourceIdSet

Use flat_set for ResourceIdSet

For DeclareUsedResourcesFromChild, the caller can accumulate into a
vector and create a flat_set from that.
ResourceProvider::wants_promotion_hints_set_ should always be small
(around 1 entry) so it should be more efficient as a flat_set.

Also remove Child::parent_to_child_map and store the child id directly
in the Resource, to avoid unnecessary map lookups on resource creation
and destruction.

This improves the performance of SurfaceAggregatorPerfTest.* by 25-30%

BUG=712295
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2826583002
Cr-Commit-Position: refs/heads/master@{#465064}
Committed: https://chromium.googlesource.com/chromium/src/+/2ef85417acbbcbb4e8852bed450ea7ac3a5965b8

[jbauman, 2017-04-17 22:05:36]

Description was changed from

==========
Use flat_set for ResourceIdSet

For DeclareUsedResourcesFromChild, the caller can accumulate into a
vector and create a flat_set from that.
ResourceProvider::wants_promotion_hints_set_ should always be small
(around 1 entry) so it should be more efficient as a flat_set.

Also remove Child::parent_to_child_map and store the child id directly
in the Resource, to avoid unnecessary map lookups on resource creation
and destruction.

This improves the performance of SurfaceAggregatorPerfTest.* by 25-30%

BUG=712295
==========

to

==========
Use flat_set for ResourceIdSet

For DeclareUsedResourcesFromChild, the caller can accumulate into a
vector and create a flat_set from that.
ResourceProvider::wants_promotion_hints_set_ should always be small
(around 1 entry) so it should be more efficient as a flat_set.

Also remove Child::parent_to_child_map and store the child id directly
in the Resource, to avoid unnecessary map lookups on resource creation
and destruction.

This improves the performance of SurfaceAggregatorPerfTest.* by 25-30%

BUG=712295
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[jbauman, 2017-04-17 22:07:16]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 22:07:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbauman, 2017-04-17 23:04:13]

jbauman@chromium.org changed reviewers:
+ enne@chromium.org

[commit-bot: I haz the power, 2017-04-17 23:07:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 23:07:16]

Dry run: This issue passed the CQ dry run.

[brettw, 2017-04-17 23:34:13]

brettw@chromium.org changed reviewers:
+ brettw@chromium.org

[brettw, 2017-04-17 23:34:13]

Awesome, thanks! LGTM

[enne (OOO), 2017-04-17 23:34:44]

enne@chromium.org changed reviewers:
- brettw@chromium.org

[enne (OOO), 2017-04-17 23:34:45]

lgtm

[jbauman, 2017-04-17 23:35:18]

The CQ bit was checked by jbauman@chromium.org

[commit-bot: I haz the power, 2017-04-17 23:35:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 23:48:44]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492472118415490, "parent_rev":
"468109cc91a8c236f4e74bd9e2dd094db5464d57", "commit_rev":
"2ef85417acbbcbb4e8852bed450ea7ac3a5965b8"}

[commit-bot: I haz the power, 2017-04-17 23:48:56]

Description was changed from

==========
Use flat_set for ResourceIdSet

For DeclareUsedResourcesFromChild, the caller can accumulate into a
vector and create a flat_set from that.
ResourceProvider::wants_promotion_hints_set_ should always be small
(around 1 entry) so it should be more efficient as a flat_set.

Also remove Child::parent_to_child_map and store the child id directly
in the Resource, to avoid unnecessary map lookups on resource creation
and destruction.

This improves the performance of SurfaceAggregatorPerfTest.* by 25-30%

BUG=712295
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Use flat_set for ResourceIdSet

For DeclareUsedResourcesFromChild, the caller can accumulate into a
vector and create a flat_set from that.
ResourceProvider::wants_promotion_hints_set_ should always be small
(around 1 entry) so it should be more efficient as a flat_set.

Also remove Child::parent_to_child_map and store the child id directly
in the Resource, to avoid unnecessary map lookups on resource creation
and destruction.

This improves the performance of SurfaceAggregatorPerfTest.* by 25-30%

BUG=712295
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2826583002
Cr-Commit-Position: refs/heads/master@{#465064}
Committed:
https://chromium.googlesource.com/chromium/src/+/2ef85417acbbcbb4e8852bed450e...
==========

[commit-bot: I haz the power, 2017-04-17 23:48:57]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2ef85417acbbcbb4e8852bed450e...