DevTools: fix tests to ensure clean revert of persistence2.0

DevTools: fix tests to ensure clean revert of persistence2.0

This patch is a preparation for the https://crrev.com/2818713007 to unbind
persistence2.0 behavior from tests.

This patch:
- enables persistencd2.0 by default in persistence-do-not-bind-dirty-sourcecode.html
  because the test verifies the binding prevalidation behavior
- fixes bug in JavaScriptSourceFrame which used wrong uiSourceCode (that's
  inevitable)

BUG=707002
R=dgozman

Review-Url: https://codereview.chromium.org/2826573002
Cr-Commit-Position: refs/heads/master@{#465153}
Committed: https://chromium.googlesource.com/chromium/src/+/3c24f4f7064cb6fcf8827bd5bd29ec12664dbd3d

[lushnikov, 2017-04-17 21:58:12]

Description was changed from

==========
fix tests to ensure clean revert

BUG=
==========

to

==========
DevTools: fix tests to ensure clean revert of persistence2.0

This patch is a preparation for the https://crrev.com/2818713007 to unbind
persistence2.0 behavior from tests.

This patch:
- enables persistencd2.0 by default in
persistence-do-not-bind-dirty-sourcecode.html
  because the test verifies the binding prevalidation behavior
- fixes bug in JavaScriptSourceFrame which used wrong uiSourceCode (that's
  inevitable)

BUG=707002
R=dgozman
==========

[lushnikov, 2017-04-17 21:58:13]

lushnikov@chromium.org changed reviewers:
+ dgozman@chromium.org

[lushnikov, 2017-04-17 21:58:28]

please, take a look

[lushnikov, 2017-04-17 21:58:38]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 21:59:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2017-04-17 22:36:02]

lgtm

https://codereview.chromium.org/2826573002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
(right):

https://codereview.chromium.org/2826573002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js:1256:
if (!TextUtils.isMinified(/** @type {string} */
(this.uiSourceCode().content())))
How could this make a difference though?

[lushnikov, 2017-04-17 23:06:13]

https://codereview.chromium.org/2826573002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
(right):

https://codereview.chromium.org/2826573002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js:1256:
if (!TextUtils.isMinified(/** @type {string} */
(this.uiSourceCode().content())))
On 2017/04/17 22:36:02, dgozman wrote:
> How could this make a difference though?

this.uiSourceCode() is the one which was requested for the content. Thus,
uiSourceCode.content() is not null at this point.

[lushnikov, 2017-04-17 23:06:21]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2017-04-17 23:06:21]

The CQ bit was unchecked by lushnikov@chromium.org

[lushnikov, 2017-04-18 04:19:51]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-04-18 04:20:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 06:20:37]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492489191415770, "parent_rev":
"52ee2d6a332741bf4a42ee01b488499e6e6ed3bb", "commit_rev":
"3c24f4f7064cb6fcf8827bd5bd29ec12664dbd3d"}

[commit-bot: I haz the power, 2017-04-18 06:21:10]

Description was changed from

==========
DevTools: fix tests to ensure clean revert of persistence2.0

This patch is a preparation for the https://crrev.com/2818713007 to unbind
persistence2.0 behavior from tests.

This patch:
- enables persistencd2.0 by default in
persistence-do-not-bind-dirty-sourcecode.html
  because the test verifies the binding prevalidation behavior
- fixes bug in JavaScriptSourceFrame which used wrong uiSourceCode (that's
  inevitable)

BUG=707002
R=dgozman
==========

to

==========
DevTools: fix tests to ensure clean revert of persistence2.0

This patch is a preparation for the https://crrev.com/2818713007 to unbind
persistence2.0 behavior from tests.

This patch:
- enables persistencd2.0 by default in
persistence-do-not-bind-dirty-sourcecode.html
  because the test verifies the binding prevalidation behavior
- fixes bug in JavaScriptSourceFrame which used wrong uiSourceCode (that's
  inevitable)

BUG=707002
R=dgozman

Review-Url: https://codereview.chromium.org/2826573002
Cr-Commit-Position: refs/heads/master@{#465153}
Committed:
https://chromium.googlesource.com/chromium/src/+/3c24f4f7064cb6fcf8827bd5bd29...
==========

[commit-bot: I haz the power, 2017-04-18 06:21:11]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3c24f4f7064cb6fcf8827bd5bd29...